From: Etienne Dechamps <etienne@edechamps.fr>
Date: Sun, 12 Oct 2014 10:41:08 +0000 (+0100)
Subject: Don't spontaneously start SPTPS with neighbors.
X-Git-Tag: release-1.1pre11~12
X-Git-Url: http://tinc-vpn.org/git/browse?a=commitdiff_plain;h=0356efecb6385b59a69bea220057396d6daa30bc;hp=0356efecb6385b59a69bea220057396d6daa30bc;p=tinc

Don't spontaneously start SPTPS with neighbors.

Currently, when tinc establishes a metaconnection, it automatically
starts a VPN SPTPS tunnel with the other side of the metaconnection.

It is not clear what this is trying to accomplish. Having a
metaconnection with a node does not necessarily mean we're going to send
packets to that node. This patch removes this behavior, thereby
simplifying code paths and removing unnecessary network chatter.

Naturally, this introduces a slight delay (as well as at least one
initial packet loss) between the moment a metaconnection is established
and the moment VPN packets can be exchanged between the two nodes.
However this is no different to the non-neighbor case, so it makes
things more consistent and therefore easier to reason about.
---