Windows TAP driver issues

[Guus Sliepen]

On Tue, Jan 16, 2018 at 03:00:03PM -0700, Todd C. Miller wrote:

> Thanks for the info, that is very helpful.  It does look like that
> change got back-ported to master, albeit in a different form.

Hm, there's indeed some differences between the two versions, even apart
from the fact that one uses a thread and the other the event system. It
seems that in write_packet(), tinc 1.0 does a ResetEvent() if a
WriteFile() succeeded immediately, but 1.1 doesn't. Also, in tinc 1.1,
for reads, ResetEvent() is called right before GetOverlappedResult(),
and that looks very suspicious... with tinc 1.0 it is called right
before ReadFile().

Overlapped IO feels alien to me.

-- 
Met vriendelijke groet / with kind regards,
     Guus Sliepen <guus at tinc-vpn.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://www.tinc-vpn.org/pipermail/tinc/attachments/20180116/15022fb0/attachment.sig>