/*
logger.c -- logging code
- Copyright (C) 2004-2015 Guus Sliepen <guus@tinc-vpn.org>
+ Copyright (C) 2004-2017 Guus Sliepen <guus@tinc-vpn.org>
2004-2005 Ivo Timmermans
This program is free software; you can redistribute it and/or modify
#include "logger.h"
#include "connection.h"
#include "control_common.h"
+#include "process.h"
#include "sptps.h"
-debug_t debug_level = DEBUG_NOTHING;
+int debug_level = DEBUG_NOTHING;
static logmode_t logmode = LOGMODE_STDERR;
static pid_t logpid;
static FILE *logfile = NULL;
break;
}
- if(umbilical) {
+ if(umbilical && do_detach) {
write(umbilical, message, strlen(message));
write(umbilical, "\n", 1);
}
va_start(ap, format);
int len = vsnprintf(message, sizeof message, format, ap);
+ message[sizeof message - 1] = 0;
va_end(ap);
- if(len > 0 && len < sizeof message && message[len - 1] == '\n')
+ if(len > 0 && len < sizeof message - 1 && message[len - 1] == '\n')
message[len - 1] = 0;
real_logger(level, priority, message);
}
static void sptps_logger(sptps_t *s, int s_errno, const char *format, va_list ap) {
- char message[1024] = "";
+ char message[1024];
size_t msglen = sizeof message;
int len = vsnprintf(message, msglen, format, ap);
- if(len > 0 && len < sizeof message) {
+ message[sizeof message - 1] = 0;
+ if(len > 0 && len < sizeof message - 1) {
if(message[len - 1] == '\n')
message[--len] = 0;
+ // WARNING: s->handle can point to a connection_t or a node_t,
+ // but both types have the name and hostname fields at the same offsets.
connection_t *c = s->handle;
if(c)
snprintf(message + len, sizeof message - len, " from %s (%s)", c->name, c->hostname);
case LOGMODE_NULL:
case LOGMODE_STDERR:
break;
- break;
}
}