X-Git-Url: https://tinc-vpn.org/git/browse?a=blobdiff_plain;ds=sidebyside;f=src%2Fraw_socket_device.c;h=1c455e6a748412b705ae748fef05ca7b8b251354;hb=09f036b3aee79d5a5357ef670924ab49de0378dd;hp=02f6afaf95f372a7012b4e164aac33e5271d9520;hpb=a6448291834ca7419553a807ee367c719c2956d0;p=tinc diff --git a/src/raw_socket_device.c b/src/raw_socket_device.c index 02f6afaf..1c455e6a 100644 --- a/src/raw_socket_device.c +++ b/src/raw_socket_device.c @@ -28,22 +28,20 @@ #include "device.h" #include "net.h" #include "logger.h" -#include "utils.h" -#include "route.h" #include "xalloc.h" #if defined(PF_PACKET) && defined(ETH_P_ALL) && defined(AF_PACKET) && defined(SIOCGIFINDEX) static const char *device_info = "raw_socket"; static bool setup_device(void) { - struct ifreq ifr; - struct sockaddr_ll sa; + struct ifreq ifr = {0}; + struct sockaddr_ll sa = {0}; - if(!get_config_string(lookup_config(config_tree, "Interface"), &iface)) { + if(!get_config_string(lookup_config(&config_tree, "Interface"), &iface)) { iface = xstrdup("eth0"); } - if(!get_config_string(lookup_config(config_tree, "Device"), &device)) { + if(!get_config_string(lookup_config(&config_tree, "Device"), &device)) { device = xstrdup(iface); } @@ -53,8 +51,6 @@ static bool setup_device(void) { return false; } - memset(&ifr, 0, sizeof(ifr)); - #ifdef FD_CLOEXEC fcntl(device_fd, F_SETFD, FD_CLOEXEC); #endif @@ -69,7 +65,6 @@ static bool setup_device(void) { return false; } - memset(&sa, '0', sizeof(sa)); sa.sll_family = AF_PACKET; sa.sll_protocol = htons(ETH_P_ALL); sa.sll_ifindex = ifr.ifr_ifindex; @@ -96,7 +91,7 @@ static void close_device(void) { } static bool read_packet(vpn_packet_t *packet) { - int inlen; + ssize_t inlen; if((inlen = read(device_fd, DATA(packet), MTU)) <= 0) { logger(DEBUG_ALWAYS, LOG_ERR, "Error while reading from %s %s: %s", device_info,