X-Git-Url: https://tinc-vpn.org/git/browse?a=blobdiff_plain;f=src%2Fconnection.c;h=4a2ba4c09110394e8654f4ecc3728484878ddf3f;hb=f1fec466e232c00c668422014029dce9114d3add;hp=06f51b50aac3e4b55dfe14ffa89d7c0321a83ee6;hpb=6eaefb4dbce240334e35f67d9f3db5d4f44e49c9;p=tinc

diff --git a/src/connection.c b/src/connection.c
index 06f51b50..4a2ba4c0 100644
--- a/src/connection.c
+++ b/src/connection.c
@@ -23,6 +23,7 @@
 #include "system.h"
 
 #include "splay_tree.h"
+#include "cipher.h"
 #include "conf.h"
 #include "list.h"
 #include "logger.h"
@@ -36,7 +37,7 @@ splay_tree_t *connection_tree;	/* Meta connections */
 connection_t *broadcast;
 
 static int connection_compare(const connection_t *a, const connection_t *b) {
-	return (void *)a - (void *)b;
+	return a < b ? -1 : a == b ? 0 : 1;
 }
 
 void init_connections(void) {
@@ -73,18 +74,15 @@ void free_connection(connection_t *c) {
 	if(c->hostname)
 		free(c->hostname);
 
-	if(c->inkey)
-		free(c->inkey);
-
-	if(c->outkey)
-		free(c->outkey);
-
-	if(c->mychallenge)
-		free(c->mychallenge);
+	cipher_close(&c->incipher);
+	cipher_close(&c->outcipher);
 
 	if(c->hischallenge)
 		free(c->hischallenge);
 
+	if(c->config_tree)
+		exit_configuration(&c->config_tree);
+
 	if(c->buffer)
 		bufferevent_free(c->buffer);
 	
@@ -115,9 +113,9 @@ int dump_connections(struct evbuffer *out) {
 	for(node = connection_tree->head; node; node = node->next) {
 		c = node->data;
 		if(evbuffer_add_printf(out,
-							   _(" %s at %s options %lx socket %d status %04x\n"),
-							   c->name, c->hostname, c->options, c->socket,
-							   c->status.value) == -1)
+				   _(" %s at %s options %lx socket %d status %04x\n"),
+				   c->name, c->hostname, c->options, c->socket,
+				   bitfield_to_int(&c->status, sizeof c->status)) == -1)
 			return errno;
 	}
 
@@ -130,7 +128,7 @@ bool read_connection_config(connection_t *c) {
 
 	cp();
 
-	asprintf(&fname, "%s/hosts/%s", confbase, c->name);
+	xasprintf(&fname, "%s/hosts/%s", confbase, c->name);
 	x = read_config_file(c->config_tree, fname);
 	free(fname);