X-Git-Url: https://tinc-vpn.org/git/browse?a=blobdiff_plain;f=src%2Fmeta.c;h=787ccbd0ff17426b709dc8683e08e3a358d6cf12;hb=7ea85043ac1fb2096baea44f6b0af27ac0d0b2cf;hp=2791ea198c2b4e4471f7e0734a613cff686cc9bf;hpb=1b8f8918360b40a2749d40355266ed7dedbe41b5;p=tinc

diff --git a/src/meta.c b/src/meta.c
index 2791ea19..787ccbd0 100644
--- a/src/meta.c
+++ b/src/meta.c
@@ -1,7 +1,8 @@
 /*
     meta.c -- handle the meta communication
-    Copyright (C) 2000-2006 Guus Sliepen <guus@tinc-vpn.org>,
+    Copyright (C) 2000-2009 Guus Sliepen <guus@tinc-vpn.org>,
                   2000-2005 Ivo Timmermans
+                  2006      Scott Lamb <slamb@slamb.org>
 
     This program is free software; you can redistribute it and/or modify
     it under the terms of the GNU General Public License as published by
@@ -13,11 +14,9 @@
     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
     GNU General Public License for more details.
 
-    You should have received a copy of the GNU General Public License
-    along with this program; if not, write to the Free Software
-    Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
-
-    $Id$
+    You should have received a copy of the GNU General Public License along
+    with this program; if not, write to the Free Software Foundation, Inc.,
+    51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 */
 
 #include "system.h"
@@ -33,9 +32,13 @@
 #include "xalloc.h"
 
 bool send_meta(connection_t *c, const char *buffer, int length) {
-	cp();
+	if(!c) {
+		logger(LOG_ERR, "send_meta() called with NULL pointer!");
+		abort();
+	}
 
-	ifdebug(META) logger(LOG_DEBUG, _("Sending %d bytes of metadata to %s (%s)"), length, c->name, c->hostname);
+	ifdebug(META) logger(LOG_DEBUG, "Sending %d bytes of metadata to %s (%s)", length,
+			   c->name, c->hostname);
 
 	/* Add our data to buffer */
 	if(c->status.encryptout) {
@@ -43,13 +46,18 @@ bool send_meta(connection_t *c, const char *buffer, int length) {
 		size_t outlen = length;
 
 		if(!cipher_encrypt(&c->outcipher, buffer, length, outbuf, &outlen, false) || outlen != length) {
-			logger(LOG_ERR, _("Error while encrypting metadata to %s (%s)"), c->name, c->hostname);
+			logger(LOG_ERR, "Error while encrypting metadata to %s (%s)",
+					c->name, c->hostname);
 			return false;
 		}
 		
+		ifdebug(META) logger(LOG_DEBUG, "Encrypted write %p %p %p %d", c, c->buffer, outbuf, length);
 		bufferevent_write(c->buffer, (void *)outbuf, length);
+		ifdebug(META) logger(LOG_DEBUG, "Done.");
 	} else {
+		ifdebug(META) logger(LOG_DEBUG, "Unencrypted write %p %p %p %d", c, c->buffer, buffer, length);
 		bufferevent_write(c->buffer, (void *)buffer, length);
+		ifdebug(META) logger(LOG_DEBUG, "Done.");
 	}
 
 	return true;
@@ -59,8 +67,6 @@ void broadcast_meta(connection_t *from, const char *buffer, int length) {
 	splay_node_t *node;
 	connection_t *c;
 
-	cp();
-
 	for(node = connection_tree->head; node; node = node->next) {
 		c = node->data;
 
@@ -74,8 +80,6 @@ bool receive_meta(connection_t *c) {
 	char inbuf[MAXBUFSIZE];
 	char *bufp = inbuf, *endp;
 
-	cp();
-
 	/* Strategy:
 	   - Read as much as possible from the TCP socket in one go.
 	   - Decrypt it.
@@ -88,7 +92,7 @@ bool receive_meta(connection_t *c) {
 	inlen = recv(c->socket, inbuf, sizeof inbuf, 0);
 
 	if(inlen <= 0) {
-		logger(LOG_ERR, _("Receive callback called for %s (%s) but no data to receive: %s"), c->name, c->hostname, strerror(errno));
+		logger(LOG_ERR, "Receive callback called for %s (%s) but no data to receive: %s", c->name, c->hostname, strerror(errno));
 		return false;
 	}
 
@@ -106,14 +110,16 @@ bool receive_meta(connection_t *c) {
 			bufp = endp;
 		} else {
 			size_t outlen = inlen;
-			evbuffer_expand(c->buffer->input, inlen);
+			ifdebug(META) logger(LOG_DEBUG, "Received encrypted %zu bytes", inlen);
+			evbuffer_expand(c->buffer->input, c->buffer->input->off + inlen);
 
-			if(!cipher_decrypt(&c->incipher, bufp, inlen, c->buffer->input->buffer, &outlen, false) || inlen != outlen) {
-				logger(LOG_ERR, _("Error while decrypting metadata from %s (%s)"), c->name, c->hostname);
+			if(!cipher_decrypt(&c->incipher, bufp, inlen, c->buffer->input->buffer + c->buffer->input->off, &outlen, false) || inlen != outlen) {
+				logger(LOG_ERR, "Error while decrypting metadata from %s (%s)",
+					   c->name, c->hostname);
 				return false;
 			}
-
 			c->buffer->input->off += inlen;
+
 			inlen = 0;
 		}