X-Git-Url: https://tinc-vpn.org/git/browse?a=blobdiff_plain;f=src%2Fnet_packet.c;h=245ce62dcb7bbc6eb34037a884b1a9314af24df2;hb=9e71b74ed83c51e0b35114a4f153b62b54fd3702;hp=40cb2bac1443783a0803e4f21e277ea252e0398f;hpb=9bb230f30f665779eb89dcce077a15360ec50be1;p=tinc diff --git a/src/net_packet.c b/src/net_packet.c index 40cb2bac..245ce62d 100644 --- a/src/net_packet.c +++ b/src/net_packet.c @@ -687,9 +687,7 @@ static bool send_sptps_data_priv(node_t *to, node_t *from, int type, const void bool relay_supported = (relay->options >> 24) >= 4; bool tcponly = (myself->options | relay->options) & OPTION_TCPONLY; - /* Send it via TCP if it is a handshake packet, TCPOnly is in use, this is a relay packet that the other node cannot understand, or this packet is larger than the MTU. - TODO: When relaying, the original sender does not know the end-to-end PMTU (it only knows the PMTU of the first hop). - This can lead to scenarios where large packets are sent over UDP to relay, but then relay has no choice but fall back to TCP. */ + /* Send it via TCP if it is a handshake packet, TCPOnly is in use, this is a relay packet that the other node cannot understand, or this packet is larger than the MTU. */ if(type == SPTPS_HANDSHAKE || tcponly || (!direct && !relay_supported) || (type != PKT_PROBE && (len - SPTPS_DATAGRAM_OVERHEAD) > relay->minmtu)) { char buf[len * 4 / 3 + 5]; @@ -1137,7 +1135,7 @@ static void try_tx_sptps(node_t *n, bool mtu) { /* If we do have a static relay, try everything with that one instead. */ if(via != n) - try_tx_sptps(via, mtu); + return try_tx_sptps(via, mtu); /* Otherwise, try to establish UDP connectivity. */ @@ -1422,6 +1420,12 @@ skip_harder: n->sock = ls - listen_socket; if(direct && sockaddrcmp(&addr, &n->address)) update_node_udp(n, &addr); + + /* If the packet went through a relay, help the sender find the appropriate MTU + through the relay path. */ + + if(!direct) + send_mtu_info(myself, n, MTU); } void handle_device_data(void *data, int flags) {