X-Git-Url: https://tinc-vpn.org/git/browse?a=blobdiff_plain;f=src%2Fnode.c;h=8f4b6eeeb018b3c1c718b9c3fc66dd22d00f4cc9;hb=refs%2Fheads%2F1.1;hp=b5e033c11a2fcd84d798fb1b005b0a4eb90a3306;hpb=1c475ecb575367a6b3f9328b0f643ad636155341;p=tinc

diff --git a/src/node.c b/src/node.c
index b5e033c1..3e37b8eb 100644
--- a/src/node.c
+++ b/src/node.c
@@ -22,7 +22,6 @@
 
 #include "address_cache.h"
 #include "control_common.h"
-#include "hash.h"
 #include "logger.h"
 #include "net.h"
 #include "netutl.h"
@@ -33,10 +32,6 @@
 
 #include "ed25519/sha512.h"
 
-splay_tree_t *node_tree;
-static splay_tree_t *node_id_tree;
-static splay_tree_t *node_udp_tree;
-
 node_t *myself;
 
 static int node_compare(const node_t *a, const node_t *b) {
@@ -57,50 +52,58 @@ static int node_udp_compare(const node_t *a, const node_t *b) {
 	return (a->name && b->name) ? strcmp(a->name, b->name) : 0;
 }
 
-void init_nodes(void) {
-	node_tree = splay_alloc_tree((splay_compare_t) node_compare, (splay_action_t) free_node);
-	node_id_tree = splay_alloc_tree((splay_compare_t) node_id_compare, NULL);
-	node_udp_tree = splay_alloc_tree((splay_compare_t) node_udp_compare, NULL);
-}
+splay_tree_t node_tree = {
+	.compare = (splay_compare_t) node_compare,
+	.delete = (splay_action_t) free_node,
+};
+
+static splay_tree_t node_id_tree = {
+	.compare = (splay_compare_t) node_id_compare,
+};
+
+static splay_tree_t node_udp_tree = {
+	.compare = (splay_compare_t) node_udp_compare,
+};
 
 void exit_nodes(void) {
-	splay_delete_tree(node_udp_tree);
-	splay_delete_tree(node_id_tree);
-	splay_delete_tree(node_tree);
+	splay_empty_tree(&node_udp_tree);
+	splay_empty_tree(&node_id_tree);
+	splay_empty_tree(&node_tree);
 }
 
-node_t *new_node(void) {
+node_t *new_node(const char *name) {
 	node_t *n = xzalloc(sizeof(*n));
 
 	if(replaywin) {
 		n->late = xzalloc(replaywin);
 	}
 
-	n->subnet_tree = new_subnet_tree();
-	n->edge_tree = new_edge_tree();
+	init_subnet_tree(&n->subnet_tree);
+	init_edge_tree(&n->edge_tree);
+
 	n->mtu = MTU;
 	n->maxmtu = MTU;
 	n->udp_ping_rtt = -1;
+	n->name = xstrdup(name);
 
 	return n;
 }
 
 void free_node(node_t *n) {
-	if(n->subnet_tree) {
-		free_subnet_tree(n->subnet_tree);
+	if(!n) {
+		return;
 	}
 
-	if(n->edge_tree) {
-		free_edge_tree(n->edge_tree);
-	}
+	splay_empty_tree(&n->subnet_tree);
+	splay_empty_tree(&n->edge_tree);
 
 	sockaddrfree(&n->address);
 
 #ifndef DISABLE_LEGACY
-	cipher_close(n->incipher);
-	digest_close(n->indigest);
-	cipher_close(n->outcipher);
-	digest_close(n->outdigest);
+	cipher_free(n->incipher);
+	digest_free(n->indigest);
+	cipher_free(n->outcipher);
+	digest_free(n->outdigest);
 #endif
 
 	ecdsa_free(n->ecdsa);
@@ -108,17 +111,9 @@ void free_node(node_t *n) {
 
 	timeout_del(&n->udp_ping_timeout);
 
-	if(n->hostname) {
-		free(n->hostname);
-	}
-
-	if(n->name) {
-		free(n->name);
-	}
-
-	if(n->late) {
-		free(n->late);
-	}
+	free(n->hostname);
+	free(n->name);
+	free(n->late);
 
 	if(n->address_cache) {
 		close_address_cache(n->address_cache);
@@ -132,23 +127,23 @@ void node_add(node_t *n) {
 	sha512(n->name, strlen(n->name), buf);
 	memcpy(&n->id, buf, sizeof(n->id));
 
-	splay_insert(node_tree, n);
-	splay_insert(node_id_tree, n);
+	splay_insert(&node_tree, n);
+	splay_insert(&node_id_tree, n);
 }
 
 void node_del(node_t *n) {
-	splay_delete(node_udp_tree, n);
+	splay_delete(&node_udp_tree, n);
 
-	for splay_each(subnet_t, s, n->subnet_tree) {
+	for splay_each(subnet_t, s, &n->subnet_tree) {
 		subnet_del(n, s);
 	}
 
-	for splay_each(edge_t, e, n->edge_tree) {
+	for splay_each(edge_t, e, &n->edge_tree) {
 		edge_del(e);
 	}
 
-	splay_delete(node_id_tree, n);
-	splay_delete(node_tree, n);
+	splay_delete(&node_id_tree, n);
+	splay_delete(&node_tree, n);
 }
 
 node_t *lookup_node(char *name) {
@@ -156,17 +151,17 @@ node_t *lookup_node(char *name) {
 
 	n.name = name;
 
-	return splay_search(node_tree, &n);
+	return splay_search(&node_tree, &n);
 }
 
 node_t *lookup_node_id(const node_id_t *id) {
 	node_t n = {.id = *id};
-	return splay_search(node_id_tree, &n);
+	return splay_search(&node_id_tree, &n);
 }
 
 node_t *lookup_node_udp(const sockaddr_t *sa) {
 	node_t tmp = {.address = *sa};
-	return splay_search(node_udp_tree, &tmp);
+	return splay_search(&node_udp_tree, &tmp);
 }
 
 void update_node_udp(node_t *n, const sockaddr_t *sa) {
@@ -175,7 +170,7 @@ void update_node_udp(node_t *n, const sockaddr_t *sa) {
 		return;
 	}
 
-	splay_delete(node_udp_tree, n);
+	splay_delete(&node_udp_tree, n);
 
 	if(sa) {
 		n->address = *sa;
@@ -188,7 +183,7 @@ void update_node_udp(node_t *n, const sockaddr_t *sa) {
 			}
 		}
 
-		splay_insert(node_udp_tree, n);
+		splay_insert(&node_udp_tree, n);
 		free(n->hostname);
 		n->hostname = sockaddr2hostname(&n->address);
 		logger(DEBUG_PROTOCOL, LOG_DEBUG, "UDP address of %s set to %s", n->name, n->hostname);
@@ -204,7 +199,7 @@ void update_node_udp(node_t *n, const sockaddr_t *sa) {
 }
 
 bool dump_nodes(connection_t *c) {
-	for splay_each(node_t, n, node_tree) {
+	for splay_each(node_t, n, &node_tree) {
 		char id[2 * sizeof(n->id) + 1];
 
 		for(size_t c = 0; c < sizeof(n->id); ++c) {
@@ -212,14 +207,14 @@ bool dump_nodes(connection_t *c) {
 		}
 
 		id[sizeof(id) - 1] = 0;
-		send_request(c, "%d %d %s %s %s %d %d %d %d %x %x %s %s %d %d %d %d %ld %d %"PRIu64" %"PRIu64" %"PRIu64" %"PRIu64, CONTROL, REQ_DUMP_NODES,
+		send_request(c, "%d %d %s %s %s %d %d %lu %d %x %x %s %s %d %d %d %d %ld %d %"PRIu64" %"PRIu64" %"PRIu64" %"PRIu64, CONTROL, REQ_DUMP_NODES,
 		             n->name, id, n->hostname ? n->hostname : "unknown port unknown",
 #ifdef DISABLE_LEGACY
-		             0, 0, 0,
+		             0, 0, 0UL,
 #else
-		             cipher_get_nid(n->outcipher), digest_get_nid(n->outdigest), (int)digest_length(n->outdigest),
+		             cipher_get_nid(n->outcipher), digest_get_nid(n->outdigest), (unsigned long)digest_length(n->outdigest),
 #endif
-		             n->outcompression, n->options, bitfield_to_int(&n->status, sizeof(n->status)),
+		             n->outcompression, n->options, n->status.value,
 		             n->nexthop ? n->nexthop->name : "-", n->via && n->via->name ? n->via->name : "-", n->distance,
 		             n->mtu, n->minmtu, n->maxmtu, (long)n->last_state_change, n->udp_ping_rtt,
 		             n->in_packets, n->in_bytes, n->out_packets, n->out_bytes);
@@ -229,7 +224,7 @@ bool dump_nodes(connection_t *c) {
 }
 
 bool dump_traffic(connection_t *c) {
-	for splay_each(node_t, n, node_tree)
+	for splay_each(node_t, n, &node_tree)
 		send_request(c, "%d %d %s %"PRIu64" %"PRIu64" %"PRIu64" %"PRIu64, CONTROL, REQ_DUMP_TRAFFIC,
 		             n->name, n->in_packets, n->in_bytes, n->out_packets, n->out_bytes);