X-Git-Url: https://tinc-vpn.org/git/browse?a=blobdiff_plain;f=src%2Fprotocol.c;h=fc16ffe7c08b66166e114094daab6dd814e78a29;hb=079dcd01794187d2857e1233f6c9930310812593;hp=1c5b6cfd9c1d43dba0c6a2e21defabdb4c431209;hpb=19be9cf7150858311f7898fa3fb525d692d02f64;p=tinc

diff --git a/src/protocol.c b/src/protocol.c
index 1c5b6cfd..fc16ffe7 100644
--- a/src/protocol.c
+++ b/src/protocol.c
@@ -56,6 +56,9 @@ static char (*request_name[]) = {
 static splay_tree_t *past_request_tree;
 
 bool check_id(const char *id) {
+	if(!id || !*id)
+		return false;
+
 	for(; *id; id++)
 		if(!isalnum(*id) && *id != '_')
 			return false;
@@ -108,7 +111,7 @@ void forward_request(connection_t *from, const char *request) {
 }
 
 bool receive_request(connection_t *c, const char *request) {
-	if(proxytype == PROXY_HTTP && c->allow_request == ID) {
+	if(c->outgoing && proxytype == PROXY_HTTP && c->allow_request == ID) {
 		if(!request[0] || request[0] == '\r')
 			return true;
 		if(!strncasecmp(request, "HTTP/1.1 ", 9)) {
@@ -162,7 +165,24 @@ static void free_past_request(past_request_t *r) {
 	free(r);
 }
 
-static struct event past_request_event;
+static timeout_t past_request_timeout;
+
+static void age_past_requests(void *data) {
+	int left = 0, deleted = 0;
+
+	for splay_each(past_request_t, p, past_request_tree) {
+		if(p->firstseen + pinginterval <= now.tv_sec)
+			splay_delete_node(past_request_tree, node), deleted++;
+		else
+			left++;
+	}
+
+	if(left || deleted)
+		logger(DEBUG_SCARY_THINGS, LOG_DEBUG, "Aging past requests: deleted %d, left %d", deleted, left);
+
+	if(left)
+		timeout_set(&past_request_timeout, &(struct timeval){10, rand() % 100000});
+}
 
 bool seen_request(const char *request) {
 	past_request_t *new, p = {NULL};
@@ -177,44 +197,17 @@ bool seen_request(const char *request) {
 		new->request = xstrdup(request);
 		new->firstseen = time(NULL);
 		splay_insert(past_request_tree, new);
-		event_add(&past_request_event, &(struct timeval){10, 0});
+		timeout_add(&past_request_timeout, age_past_requests, NULL, &(struct timeval){10, rand() % 100000});
 		return false;
 	}
 }
 
-static void age_past_requests(int fd, short events, void *data) {
-	splay_node_t *node, *next;
-	past_request_t *p;
-	int left = 0, deleted = 0;
-	time_t now = time(NULL);
-
-	for(node = past_request_tree->head; node; node = next) {
-		next = node->next;
-		p = node->data;
-
-		if(p->firstseen + pinginterval <= now)
-			splay_delete_node(past_request_tree, node), deleted++;
-		else
-			left++;
-	}
-
-	if(left || deleted)
-		logger(DEBUG_SCARY_THINGS, LOG_DEBUG, "Aging past requests: deleted %d, left %d",
-			   deleted, left);
-
-	if(left)
-		event_add(&past_request_event, &(struct timeval){10, 0});
-}
-
 void init_requests(void) {
 	past_request_tree = splay_alloc_tree((splay_compare_t) past_request_compare, (splay_action_t) free_past_request);
-
-	timeout_set(&past_request_event, age_past_requests, NULL);
 }
 
 void exit_requests(void) {
 	splay_delete_tree(past_request_tree);
 
-	if(timeout_initialized(&past_request_event))
-		event_del(&past_request_event);
+	timeout_del(&past_request_timeout);
 }