Fix a possible segmentation fault during key upgrades.

read_rsa_public_key() was bailing out early if the given node already has an Ed25519 key, and
returned true even though c->rsa was NULL. The early bailout code isn't necessary anymore, so just
remove it.

diff --git a/src/net_setup.c b/src/net_setup.c
index c4f01b5..3c66c13 100644 (file)
--- a/src/net_setup.c
+++ b/src/net_setup.c
@@ -148,9 +148,6 @@ bool read_ecdsa_public_key(connection_t *c) {
 
 #ifndef DISABLE_LEGACY
 bool read_rsa_public_key(connection_t *c) {
-       if(ecdsa_active(c->ecdsa))
-               return true;
-
        FILE *fp;
        char *fname;
        char *n;