From: Mathew Heard <splitice@users.noreply.github.com>
Date: Tue, 29 Jun 2021 05:03:50 +0000 (+1000)
Subject: Fail early in send_udp_probe_packet().
X-Git-Url: https://tinc-vpn.org/git/browse?a=commitdiff_plain;h=bceaa804d57ac88f5201886d48738975ee2ae8c2;p=tinc

Fail early in send_udp_probe_packet().
---

diff --git a/src/net_packet.c b/src/net_packet.c
index ac70d6be..8a5460cb 100644
--- a/src/net_packet.c
+++ b/src/net_packet.c
@@ -1085,14 +1085,14 @@ static void try_sptps(node_t *n) {
 
 static void send_udp_probe_packet(node_t *n, int len) {
 	vpn_packet_t packet;
-	packet.offset = DEFAULT_PACKET_OFFSET;
-	memset(DATA(&packet), 0, 14);
 
 	if(len > sizeof(packet.data)) {
 		logger(DEBUG_TRAFFIC, LOG_INFO, "Truncating probe length %d to %s (%s)", len, n->name, n->hostname);
 		len = sizeof(packet.data);
 	}
 
+	packet.offset = DEFAULT_PACKET_OFFSET;
+	memset(DATA(&packet), 0, 14);
 	randomize(DATA(&packet) + 14, len - 14);
 	packet.len = len;
 	packet.priority = 0;