Fix whitespace.
[tinc] / src / net_setup.c
index f07bdda..462ff10 100644 (file)
@@ -22,7 +22,6 @@
 
 #include "system.h"
 
-#include "splay_tree.h"
 #include "cipher.h"
 #include "conf.h"
 #include "connection.h"
@@ -52,20 +51,23 @@ char *proxyuser;
 char *proxypass;
 proxytype_t proxytype;
 
+char *scriptinterpreter;
+char *scriptextension;
+
 bool node_read_ecdsa_public_key(node_t *n) {
        if(ecdsa_active(&n->ecdsa))
                return true;
 
        splay_tree_t *config_tree;
        FILE *fp;
-       char *fname;
+       char *pubname = NULL, *hcfname = NULL;
        char *p;
        bool result = false;
 
-       xasprintf(&fname, "%s" SLASH "hosts" SLASH "%s", confbase, n->name);
+       xasprintf(&hcfname, "%s" SLASH "hosts" SLASH "%s", confbase, n->name);
 
        init_configuration(&config_tree);
-       if(!read_config_file(config_tree, fname))
+       if(!read_config_file(config_tree, hcfname))
                goto exit;
 
        /* First, check for simple ECDSAPublicKey statement */
@@ -78,15 +80,13 @@ bool node_read_ecdsa_public_key(node_t *n) {
 
        /* Else, check for ECDSAPublicKeyFile statement and read it */
 
-       free(fname);
+       if(!get_config_string(lookup_config(config_tree, "ECDSAPublicKeyFile"), &pubname))
+               xasprintf(&pubname, "%s" SLASH "hosts" SLASH "%s", confbase, n->name);
 
-       if(!get_config_string(lookup_config(config_tree, "ECDSAPublicKeyFile"), &fname))
-               xasprintf(&fname, "%s" SLASH "hosts" SLASH "%s", confbase, n->name);
-
-       fp = fopen(fname, "r");
+       fp = fopen(pubname, "r");
 
        if(!fp) {
-               logger(DEBUG_ALWAYS, LOG_ERR, "Error reading ECDSA public key file `%s': %s", fname, strerror(errno));
+               logger(DEBUG_ALWAYS, LOG_ERR, "Error reading ECDSA public key file `%s': %s", pubname, strerror(errno));
                goto exit;
        }
 
@@ -95,7 +95,8 @@ bool node_read_ecdsa_public_key(node_t *n) {
 
 exit:
        exit_configuration(&config_tree);
-       free(fname);
+       free(hcfname);
+       free(pubname);
        return result;
 }
 
@@ -166,7 +167,7 @@ bool read_rsa_public_key(connection_t *c) {
        result = rsa_read_pem_public_key(&c->rsa, fp);
        fclose(fp);
 
-       if(!result) 
+       if(!result)
                logger(DEBUG_ALWAYS, LOG_ERR, "Reading RSA public key file `%s' failed: %s", fname, strerror(errno));
        free(fname);
        return result;
@@ -206,7 +207,7 @@ static bool read_ecdsa_private_key(void) {
        result = ecdsa_read_pem_private_key(&myself->connection->ecdsa, fp);
        fclose(fp);
 
-       if(!result) 
+       if(!result)
                logger(DEBUG_ALWAYS, LOG_ERR, "Reading ECDSA private key file `%s' failed: %s", fname, strerror(errno));
        free(fname);
        return result;
@@ -262,7 +263,7 @@ static bool read_rsa_private_key(void) {
        result = rsa_read_pem_private_key(&myself->connection->rsa, fp);
        fclose(fp);
 
-       if(!result) 
+       if(!result)
                logger(DEBUG_ALWAYS, LOG_ERR, "Reading RSA private key file `%s' failed: %s", fname, strerror(errno));
        free(fname);
        return result;
@@ -293,11 +294,6 @@ void load_all_subnets(void) {
        DIR *dir;
        struct dirent *ent;
        char *dname;
-       char *fname;
-       splay_tree_t *config_tree;
-       config_t *cfg;
-       subnet_t *s, *s2;
-       node_t *n;
 
        xasprintf(&dname, "%s" SLASH "hosts", confbase);
        dir = opendir(dname);
@@ -311,13 +307,16 @@ void load_all_subnets(void) {
                if(!check_id(ent->d_name))
                        continue;
 
-               n = lookup_node(ent->d_name);
+               node_t *n = lookup_node(ent->d_name);
                #ifdef _DIRENT_HAVE_D_TYPE
                //if(ent->d_type != DT_REG)
                //      continue;
                #endif
 
+               char *fname;
                xasprintf(&fname, "%s" SLASH "hosts" SLASH "%s", confbase, ent->d_name);
+
+               splay_tree_t *config_tree;
                init_configuration(&config_tree);
                read_config_options(config_tree, ent->d_name);
                read_config_file(config_tree, fname);
@@ -329,7 +328,9 @@ void load_all_subnets(void) {
                        node_add(n);
                }
 
-               for(cfg = lookup_config(config_tree, "Subnet"); cfg; cfg = lookup_config_next(config_tree, cfg)) {
+               for(config_t *cfg = lookup_config(config_tree, "Subnet"); cfg; cfg = lookup_config_next(config_tree, cfg)) {
+                       subnet_t *s, *s2;
+
                        if(!get_config_subnet(cfg, &s))
                                continue;
 
@@ -386,11 +387,26 @@ char *get_name(void) {
 
 bool setup_myself_reloadable(void) {
        char *proxy = NULL;
-       char *mode = NULL;
+       char *rmode = NULL;
+       char *fmode = NULL;
+       char *bmode = NULL;
        char *afname = NULL;
        char *space;
        bool choice;
 
+       free(scriptinterpreter);
+       scriptinterpreter = NULL;
+       get_config_string(lookup_config(config_tree, "ScriptsInterpreter"), &scriptinterpreter);
+
+
+       free(scriptextension);
+       if(!get_config_string(lookup_config(config_tree, "ScriptsExtension"), &scriptextension))
+#ifdef HAVE_MINGW
+               scriptextension = xstrdup(".bat");
+#else
+               scriptextension = xstrdup("");
+#endif
+
        get_config_string(lookup_config(config_tree, "Proxy"), &proxy);
        if(proxy) {
                if((space = strchr(proxy, ' ')))
@@ -464,33 +480,33 @@ bool setup_myself_reloadable(void) {
 
        get_config_bool(lookup_config(config_tree, "DirectOnly"), &directonly);
        get_config_bool(lookup_config(config_tree, "LocalDiscovery"), &localdiscovery);
-       
-       if(get_config_string(lookup_config(config_tree, "Mode"), &mode)) {
-               if(!strcasecmp(mode, "router"))
+
+       if(get_config_string(lookup_config(config_tree, "Mode"), &rmode)) {
+               if(!strcasecmp(rmode, "router"))
                        routing_mode = RMODE_ROUTER;
-               else if(!strcasecmp(mode, "switch"))
+               else if(!strcasecmp(rmode, "switch"))
                        routing_mode = RMODE_SWITCH;
-               else if(!strcasecmp(mode, "hub"))
+               else if(!strcasecmp(rmode, "hub"))
                        routing_mode = RMODE_HUB;
                else {
                        logger(DEBUG_ALWAYS, LOG_ERR, "Invalid routing mode!");
                        return false;
                }
-               free(mode);
+               free(rmode);
        }
 
-       if(get_config_string(lookup_config(config_tree, "Forwarding"), &mode)) {
-               if(!strcasecmp(mode, "off"))
+       if(get_config_string(lookup_config(config_tree, "Forwarding"), &fmode)) {
+               if(!strcasecmp(fmode, "off"))
                        forwarding_mode = FMODE_OFF;
-               else if(!strcasecmp(mode, "internal"))
+               else if(!strcasecmp(fmode, "internal"))
                        forwarding_mode = FMODE_INTERNAL;
-               else if(!strcasecmp(mode, "kernel"))
+               else if(!strcasecmp(fmode, "kernel"))
                        forwarding_mode = FMODE_KERNEL;
                else {
                        logger(DEBUG_ALWAYS, LOG_ERR, "Invalid forwarding mode!");
                        return false;
                }
-               free(mode);
+               free(fmode);
        }
 
        choice = true;
@@ -505,18 +521,18 @@ bool setup_myself_reloadable(void) {
 
        get_config_bool(lookup_config(config_tree, "PriorityInheritance"), &priorityinheritance);
        get_config_bool(lookup_config(config_tree, "DecrementTTL"), &decrement_ttl);
-       if(get_config_string(lookup_config(config_tree, "Broadcast"), &mode)) {
-               if(!strcasecmp(mode, "no"))
+       if(get_config_string(lookup_config(config_tree, "Broadcast"), &bmode)) {
+               if(!strcasecmp(bmode, "no"))
                        broadcast_mode = BMODE_NONE;
-               else if(!strcasecmp(mode, "yes") || !strcasecmp(mode, "mst"))
+               else if(!strcasecmp(bmode, "yes") || !strcasecmp(bmode, "mst"))
                        broadcast_mode = BMODE_MST;
-               else if(!strcasecmp(mode, "direct"))
+               else if(!strcasecmp(bmode, "direct"))
                        broadcast_mode = BMODE_DIRECT;
                else {
                        logger(DEBUG_ALWAYS, LOG_ERR, "Invalid broadcast mode!");
                        return false;
                }
-               free(mode);
+               free(bmode);
        }
 
 #if !defined(SOL_IP) || !defined(IP_TOS)
@@ -561,15 +577,9 @@ bool setup_myself_reloadable(void) {
   Configure node_t myself and set up the local sockets (listen only)
 */
 static bool setup_myself(void) {
-       config_t *cfg;
-       subnet_t *subnet;
        char *name, *hostname, *cipher, *digest, *type;
        char *fname = NULL;
        char *address = NULL;
-       char *envp[5];
-       struct addrinfo *ai, *aip, hint = {0};
-       int i, err;
-       int replaywin_int;
 
        if(!(name = get_name())) {
                logger(DEBUG_ALWAYS, LOG_ERR, "Name for tinc daemon required!");
@@ -617,15 +627,13 @@ static bool setup_myself(void) {
 
        /* Read in all the subnets specified in the host configuration file */
 
-       cfg = lookup_config(config_tree, "Subnet");
+       for(config_t *cfg = lookup_config(config_tree, "Subnet"); cfg; cfg = lookup_config_next(config_tree, cfg)) {
+               subnet_t *subnet;
 
-       while(cfg) {
                if(!get_config_subnet(cfg, &subnet))
                        return false;
 
                subnet_add(myself, subnet);
-
-               cfg = lookup_config_next(config_tree, cfg);
        }
 
        /* Check some options */
@@ -653,6 +661,7 @@ static bool setup_myself(void) {
                }
        }
 
+       int replaywin_int;
        if(get_config_int(lookup_config(config_tree, "ReplayWindow"), &replaywin_int)) {
                if(replaywin_int < 0) {
                        logger(DEBUG_ALWAYS, LOG_ERR, "ReplayWindow cannot be negative!");
@@ -671,6 +680,8 @@ static bool setup_myself(void) {
                return false;
        }
 
+       free(cipher);
+
        regenerate_key();
 
        /* Check if we want to use message authentication codes... */
@@ -691,6 +702,8 @@ static bool setup_myself(void) {
                return false;
        }
 
+       free(digest);
+
        /* Compression */
 
        if(get_config_int(lookup_config(config_tree, "Compression"), &myself->incompression)) {
@@ -752,6 +765,7 @@ static bool setup_myself(void) {
        }
 
        /* Run tinc-up script to further initialize the tap interface */
+       char *envp[5];
        xasprintf(&envp[0], "NETNAME=%s", netname ? : "");
        xasprintf(&envp[1], "DEVICE=%s", device ? : "");
        xasprintf(&envp[2], "INTERFACE=%s", iface ? : "");
@@ -760,7 +774,7 @@ static bool setup_myself(void) {
 
        execute_script("tinc-up", envp);
 
-       for(i = 0; i < 4; i++)
+       for(int i = 0; i < 4; i++)
                free(envp[i]);
 
        /* Run subnet-up scripts for our own subnets */
@@ -783,7 +797,7 @@ static bool setup_myself(void) {
                        return false;
                }
 
-               for(i = 0; i < listen_sockets; i++) {
+               for(int i = 0; i < listen_sockets; i++) {
                        salen = sizeof sa;
                        if(getsockname(i + 3, &sa.sa, &salen) < 0) {
                                logger(DEBUG_ALWAYS, LOG_ERR, "Could not get address of listen fd %d: %s", i + 3, sockstrerror(errno));
@@ -793,7 +807,7 @@ static bool setup_myself(void) {
                        listen_socket[i].tcp = i + 3;
 
 #ifdef FD_CLOEXEC
-                       fcntl(i + 3, F_SETFD, FD_CLOEXEC);
+                       fcntl(i + 3, F_SETFD, FD_CLOEXEC);
 #endif
 
                        listen_socket[i].udp = setup_vpn_in_socket(&sa);
@@ -822,7 +836,7 @@ static bool setup_myself(void) {
                }
        } else {
                listen_sockets = 0;
-               cfg = lookup_config(config_tree, "BindToAddress");
+               config_t *cfg = lookup_config(config_tree, "BindToAddress");
 
                do {
                        get_config_string(cfg, &address);
@@ -842,12 +856,13 @@ static bool setup_myself(void) {
                                        *address = 0;
                        }
 
+                       struct addrinfo *ai, hint = {0};
                        hint.ai_family = addressfamily;
                        hint.ai_socktype = SOCK_STREAM;
                        hint.ai_protocol = IPPROTO_TCP;
                        hint.ai_flags = AI_PASSIVE;
 
-                       err = getaddrinfo(address && *address ? address : NULL, port, &hint, &ai);
+                       int err = getaddrinfo(address && *address ? address : NULL, port, &hint, &ai);
                        free(address);
 
                        if(err || !ai) {
@@ -856,7 +871,7 @@ static bool setup_myself(void) {
                                return false;
                        }
 
-                       for(aip = ai; aip; aip = aip->ai_next) {
+                       for(struct addrinfo *aip = ai; aip; aip = aip->ai_next) {
                                if(listen_sockets >= MAXSOCKETS) {
                                        logger(DEBUG_ALWAYS, LOG_ERR, "Too many listening sockets");
                                        return false;
@@ -955,14 +970,9 @@ bool setup_network(void) {
   close all open network connections
 */
 void close_network_connections(void) {
-       splay_node_t *node, *next;
-       connection_t *c;
-       char *envp[5];
-       int i;
-
-       for(node = connection_tree->head; node; node = next) {
+       for(list_node_t *node = connection_list->head, *next; node; node = next) {
                next = node->next;
-               c = node->data;
+               connection_t *c = node->data;
                /* Keep control connections open until the end, so they know when we really terminated */
                if(c->status.control)
                        c->socket = -1;
@@ -978,13 +988,14 @@ void close_network_connections(void) {
                free_connection(myself->connection);
        }
 
-       for(i = 0; i < listen_sockets; i++) {
+       for(int i = 0; i < listen_sockets; i++) {
                event_del(&listen_socket[i].ev_tcp);
                event_del(&listen_socket[i].ev_udp);
                close(listen_socket[i].tcp);
                close(listen_socket[i].udp);
        }
 
+       char *envp[5];
        xasprintf(&envp[0], "NETNAME=%s", netname ? : "");
        xasprintf(&envp[1], "DEVICE=%s", device ? : "");
        xasprintf(&envp[2], "INTERFACE=%s", iface ? : "");
@@ -1001,7 +1012,7 @@ void close_network_connections(void) {
 
        if(myport) free(myport);
 
-       for(i = 0; i < 4; i++)
+       for(int i = 0; i < 4; i++)
                free(envp[i]);
 
        devops.close();