along with this program; if not, write to the Free Software
Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
- $Id: process.c,v 1.1.2.64 2003/08/08 12:55:05 guus Exp $
+ $Id: process.c,v 1.1.2.68 2003/08/08 19:56:11 guus Exp $
*/
#include "system.h"
bool install_service(void) {
char command[4096] = "";
char **argp;
+ bool space;
manager = OpenSCManager(NULL, NULL, SC_MANAGER_ALL_ACCESS);
if(!manager) {
strncat(command, program_name, sizeof(command));
for(argp = g_argv + 1; *argp; argp++) {
+ space = strchr(*argp, ' ');
strncat(command, " ", sizeof(command));
+
+ if(space)
+ strncat(command, "\"", sizeof(command));
+
strncat(command, *argp, sizeof(command));
+
+ if(space)
+ strncat(command, "\"", sizeof(command));
}
service = CreateService(manager, identname, identname,
return true;
}
-#ifdef HAVE_FORK
-/*
- Execute the program name, with sane environment.
-*/
-static void _execute_script(const char *scriptname, char **envp)
- __attribute__ ((__noreturn__));
-static void _execute_script(const char *scriptname, char **envp)
-{
- int save_errno;
-
- cp();
-
- while(*envp)
- putenv(*envp++);
-
- chdir("/");
-
- closelogger();
-
- /* Close all file descriptors */
- fcloseall();
-
- execl(scriptname, scriptname, NULL);
- /* No return on success */
-
- save_errno = errno;
-
- openlogger(identname, use_logfile?LOGMODE_FILE:(do_detach?LOGMODE_SYSLOG:LOGMODE_STDERR));
- logger(LOG_ERR, _("Could not execute `%s': %s"), scriptname,
- strerror(save_errno));
- exit(save_errno);
-}
-#endif
-
-/*
- Fork and execute the program pointed to by name.
-*/
bool execute_script(const char *name, char **envp)
{
-#ifdef HAVE_FORK
+#ifdef HAVE_SYSTEM
pid_t pid;
int status;
struct stat s;
cp();
- asprintf(&scriptname, "%s/%s", confbase, name);
+ asprintf(&scriptname, "\"%s/%s\"", confbase, name);
+#ifndef HAVE_MINGW
/* First check if there is a script */
if(stat(scriptname, &s))
return true;
- pid = fork();
+ ifdebug(STATUS) logger(LOG_INFO, _("Executing script %s"), name);
+#endif
+
+#ifdef HAVE_PUTENV
+ /* Set environment */
+
+ while(*envp)
+ putenv(*envp++);
+#endif
- if(pid < 0) {
- logger(LOG_ERR, _("System call `%s' failed: %s"), "fork",
- strerror(errno));
- return false;
- }
+ status = system(scriptname);
- if(pid) {
- ifdebug(STATUS) logger(LOG_INFO, _("Executing script %s"), name);
-
- free(scriptname);
-
- if(waitpid(pid, &status, 0) == pid) {
- if(WIFEXITED(status)) { /* Child exited by itself */
- if(WEXITSTATUS(status)) {
- logger(LOG_ERR, _("Process %d (%s) exited with non-zero status %d"),
- pid, name, WEXITSTATUS(status));
- return false;
- } else
- return true;
- } else if(WIFSIGNALED(status)) { /* Child was killed by a signal */
- logger(LOG_ERR, _("Process %d (%s) was killed by signal %d (%s)"), pid,
- name, WTERMSIG(status), strsignal(WTERMSIG(status)));
- return false;
- } else { /* Something strange happened */
- logger(LOG_ERR, _("Process %d (%s) terminated abnormally"), pid,
- name);
+ free(scriptname);
+
+ /* Unset environment? */
+
+#ifdef WEXITSTATUS
+ if(status != -1) {
+ if(WIFEXITED(status)) { /* Child exited by itself */
+ if(WEXITSTATUS(status)) {
+ logger(LOG_ERR, _("Process %d (%s) exited with non-zero status %d"),
+ pid, name, WEXITSTATUS(status));
return false;
}
- } else if (errno != EINTR) {
- logger(LOG_ERR, _("System call `%s' failed: %s"), "waitpid",
- strerror(errno));
+ } else if(WIFSIGNALED(status)) { /* Child was killed by a signal */
+ logger(LOG_ERR, _("Process %d (%s) was killed by signal %d (%s)"), pid,
+ name, WTERMSIG(status), strsignal(WTERMSIG(status)));
+ return false;
+ } else { /* Something strange happened */
+ logger(LOG_ERR, _("Process %d (%s) terminated abnormally"), pid,
+ name);
return false;
}
-
- /* Why do we get EINTR? */
- return true;
+ } else {
+ logger(LOG_ERR, _("System call `%s' failed: %s"), "system",
+ strerror(errno));
+ return false;
}
-
- /* Child here */
-
- _execute_script(scriptname, envp);
-#else
- return true;
#endif
+#endif
+ return true;
}