Improve performance of edge updates.
[tinc] / src / protocol_edge.c
index 75b4995..5553f43 100644 (file)
@@ -1,7 +1,8 @@
 /*
     protocol_edge.c -- handle the meta-protocol, edges
-    Copyright (C) 1999-2003 Ivo Timmermans <ivo@o2w.nl>,
-                  2000-2003 Guus Sliepen <guus@sliepen.eu.org>
+    Copyright (C) 1999-2005 Ivo Timmermans,
+                  2000-2012 Guus Sliepen <guus@tinc-vpn.org>
+                  2009      Michael Tokarev <mjt@corpit.ru>
 
     This program is free software; you can redistribute it and/or modify
     it under the terms of the GNU General Public License as published by
     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
     GNU General Public License for more details.
 
-    You should have received a copy of the GNU General Public License
-    along with this program; if not, write to the Free Software
-    Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
-
-    $Id: protocol_edge.c,v 1.1.4.18 2003/07/17 15:06:26 guus Exp $
+    You should have received a copy of the GNU General Public License along
+    with this program; if not, write to the Free Software Foundation, Inc.,
+    51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 */
 
 #include "system.h"
 
-#include "avl_tree.h"
 #include "conf.h"
 #include "connection.h"
 #include "edge.h"
 #include "utils.h"
 #include "xalloc.h"
 
-int send_add_edge(connection_t *c, edge_t *e)
-{
-       int x;
+bool send_add_edge(connection_t *c, const edge_t *e) {
+       bool x;
        char *address, *port;
 
-       cp();
-
        sockaddr2str(&e->address, &address, &port);
 
-       x = send_request(c, "%d %lx %s %s %s %s %lx %d", ADD_EDGE, random(),
-                                        e->from->name, e->to->name, address, port,
-                                        e->options, e->weight);
+       if(e->local_address.sa.sa_family) {
+               char *local_address, *local_port;
+               sockaddr2str(&e->local_address, &local_address, &local_port);
+
+               x = send_request(c, "%d %x %s %s %s %s %x %d %s %s", ADD_EDGE, rand(),
+                                                e->from->name, e->to->name, address, port,
+                                                e->options, e->weight, local_address, local_port);
+               free(local_address);
+               free(local_port);
+       } else {
+               x = send_request(c, "%d %x %s %s %s %s %x %d", ADD_EDGE, rand(),
+                                                e->from->name, e->to->name, address, port,
+                                                e->options, e->weight);
+       }
+
        free(address);
        free(port);
 
        return x;
 }
 
-int add_edge_h(connection_t *c)
-{
+bool add_edge_h(connection_t *c, const char *request) {
        edge_t *e;
        node_t *from, *to;
        char from_name[MAX_STRING_SIZE];
        char to_name[MAX_STRING_SIZE];
        char to_address[MAX_STRING_SIZE];
        char to_port[MAX_STRING_SIZE];
-       sockaddr_t address;
-       long int options;
+       char address_local[MAX_STRING_SIZE];
+       char port_local[MAX_STRING_SIZE];
+       sockaddr_t address, local_address = {{0}};
+       uint32_t options;
        int weight;
 
-       cp();
-
-       if(sscanf(c->buffer, "%*d %*x "MAX_STRING" "MAX_STRING" "MAX_STRING" "MAX_STRING" %lx %d",
-                         from_name, to_name, to_address, to_port, &options, &weight) != 6) {
-               logger(LOG_ERR, _("Got bad %s from %s (%s)"), "ADD_EDGE", c->name,
+       int parameter_count = sscanf(request, "%*d %*x "MAX_STRING" "MAX_STRING" "MAX_STRING" "MAX_STRING" %x %d "MAX_STRING" "MAX_STRING,
+                                             from_name, to_name, to_address, to_port, &options, &weight, address_local, port_local);
+       if (parameter_count != 6 && parameter_count != 8) {
+               logger(DEBUG_ALWAYS, LOG_ERR, "Got bad %s from %s (%s)", "ADD_EDGE", c->name,
                           c->hostname);
-               return -1;
+               return false;
        }
 
        /* Check if names are valid */
 
-       if(check_id(from_name)) {
-               logger(LOG_ERR, _("Got bad %s from %s (%s): %s"), "ADD_EDGE", c->name,
-                          c->hostname, _("invalid name"));
-               return -1;
-       }
-
-       if(check_id(to_name)) {
-               logger(LOG_ERR, _("Got bad %s from %s (%s): %s"), "ADD_EDGE", c->name,
-                          c->hostname, _("invalid name"));
-               return -1;
+       if(!check_id(from_name) || !check_id(to_name)) {
+               logger(DEBUG_ALWAYS, LOG_ERR, "Got bad %s from %s (%s): %s", "ADD_EDGE", c->name,
+                          c->hostname, "invalid name");
+               return false;
        }
 
-       if(seen_request(c->buffer))
-               return 0;
+       if(seen_request(request))
+               return true;
 
        /* Lookup nodes */
 
        from = lookup_node(from_name);
+       to = lookup_node(to_name);
+
+       if(tunnelserver &&
+          from != myself && from != c->node &&
+          to != myself && to != c->node) {
+               /* ignore indirect edge registrations for tunnelserver */
+               logger(DEBUG_PROTOCOL, LOG_WARNING,
+                  "Ignoring indirect %s from %s (%s)",
+                  "ADD_EDGE", c->name, c->hostname);
+               return true;
+       }
 
        if(!from) {
                from = new_node();
@@ -102,17 +114,18 @@ int add_edge_h(connection_t *c)
                node_add(from);
        }
 
-       to = lookup_node(to_name);
-
        if(!to) {
                to = new_node();
                to->name = xstrdup(to_name);
                node_add(to);
        }
 
+
        /* Convert addresses */
 
        address = str2sockaddr(to_address, to_port);
+       if(parameter_count >= 8)
+               local_address = str2sockaddr(address_local, port_local);
 
        /* Check if edge already exists */
 
@@ -121,104 +134,149 @@ int add_edge_h(connection_t *c)
        if(e) {
                if(e->weight != weight || e->options != options || sockaddrcmp(&e->address, &address)) {
                        if(from == myself) {
-                               ifdebug(PROTOCOL) logger(LOG_WARNING, _("Got %s from %s (%s) for ourself which does not match existing entry"),
+                               logger(DEBUG_PROTOCOL, LOG_WARNING, "Got %s from %s (%s) for ourself which does not match existing entry",
                                                   "ADD_EDGE", c->name, c->hostname);
                                send_add_edge(c, e);
-                               return 0;
+                               sockaddrfree(&local_address);
+                               return true;
                        } else {
-                               ifdebug(PROTOCOL) logger(LOG_WARNING, _("Got %s from %s (%s) which does not match existing entry"),
+                               logger(DEBUG_PROTOCOL, LOG_WARNING, "Got %s from %s (%s) which does not match existing entry",
                                                   "ADD_EDGE", c->name, c->hostname);
-                               edge_del(e);
+                               e->options = options;
+                               if(sockaddrcmp(&e->address, &address)) {
+                                       sockaddrfree(&e->address);
+                                       e->address = address;
+                               }
+                               if(e->weight != weight) {
+                                       avl_node_t *node = avl_unlink(edge_weight_tree, e);
+                                       e->weight = weight;
+                                       avl_insert_node(edge_weight_tree, node);
+                               }
+
                                graph();
+                               return true;
                        }
-               } else
-                       return 0;
+               } else if(sockaddrcmp(&e->local_address, &local_address)) {
+                       if(from == myself) {
+                               if(e->local_address.sa.sa_family && local_address.sa.sa_family) {
+                                       // Someone has the wrong local address for ourself. Correct then.
+                                       logger(DEBUG_PROTOCOL, LOG_WARNING, "Got %s from %s (%s) for ourself which does not match existing entry",
+                                                          "ADD_EDGE", c->name, c->hostname);
+                                       send_add_edge(c, e);
+                                       sockaddrfree(&local_address);
+                                       return true;
+                               }
+                               // Otherwise, just ignore it.
+                               sockaddrfree(&local_address);
+                               return true;
+                       } else if(local_address.sa.sa_family && local_address.sa.sa_family != AF_UNKNOWN) {
+                               // We learned a new local address for this edge.
+                               // local_address.sa.sa_family will be 0 if we got it from older tinc versions
+                               // local_address.sa.sa_family will be 255 (AF_UNKNOWN) if we got it from newer versions
+                               // but for edge which does not have local_address
+                               sockaddrfree(&e->local_address);
+                               e->local_address = local_address;
+
+                               // Tell others about it.
+                               if(!tunnelserver)
+                                       forward_request(c, request);
+
+                               return true;
+                       } else {
+                               sockaddrfree(&local_address);
+                               return true;
+                       }
+               } else {
+                       sockaddrfree(&local_address);
+                       return true;
+               }
        } else if(from == myself) {
-               ifdebug(PROTOCOL) logger(LOG_WARNING, _("Got %s from %s (%s) for ourself which does not exist"),
+               logger(DEBUG_PROTOCOL, LOG_WARNING, "Got %s from %s (%s) for ourself which does not exist",
                                   "ADD_EDGE", c->name, c->hostname);
+               contradicting_add_edge++;
                e = new_edge();
                e->from = from;
                e->to = to;
                send_del_edge(c, e);
                free_edge(e);
-               return 0;
+               sockaddrfree(&local_address);
+               return true;
        }
 
        e = new_edge();
        e->from = from;
        e->to = to;
        e->address = address;
+       e->local_address = local_address;
        e->options = options;
        e->weight = weight;
        edge_add(e);
 
        /* Tell the rest about the new edge */
 
-       forward_request(c);
+       if(!tunnelserver)
+               forward_request(c, request);
 
        /* Run MST before or after we tell the rest? */
 
        graph();
 
-       return 0;
+       return true;
 }
 
-int send_del_edge(connection_t *c, edge_t *e)
-{
-       cp();
-
-       return send_request(c, "%d %lx %s %s", DEL_EDGE, random(),
+bool send_del_edge(connection_t *c, const edge_t *e) {
+       return send_request(c, "%d %x %s %s", DEL_EDGE, rand(),
                                                e->from->name, e->to->name);
 }
 
-int del_edge_h(connection_t *c)
-{
+bool del_edge_h(connection_t *c, const char *request) {
        edge_t *e;
        char from_name[MAX_STRING_SIZE];
        char to_name[MAX_STRING_SIZE];
        node_t *from, *to;
 
-       cp();
-
-       if(sscanf(c->buffer, "%*d %*x "MAX_STRING" "MAX_STRING, from_name, to_name) != 2) {
-               logger(LOG_ERR, _("Got bad %s from %s (%s)"), "DEL_EDGE", c->name,
+       if(sscanf(request, "%*d %*x "MAX_STRING" "MAX_STRING, from_name, to_name) != 2) {
+               logger(DEBUG_ALWAYS, LOG_ERR, "Got bad %s from %s (%s)", "DEL_EDGE", c->name,
                           c->hostname);
-               return -1;
+               return false;
        }
 
        /* Check if names are valid */
 
-       if(check_id(from_name)) {
-               logger(LOG_ERR, _("Got bad %s from %s (%s): %s"), "DEL_EDGE", c->name,
-                          c->hostname, _("invalid name"));
-               return -1;
+       if(!check_id(from_name) || !check_id(to_name)) {
+               logger(DEBUG_ALWAYS, LOG_ERR, "Got bad %s from %s (%s): %s", "DEL_EDGE", c->name,
+                          c->hostname, "invalid name");
+               return false;
        }
 
-       if(check_id(to_name)) {
-               logger(LOG_ERR, _("Got bad %s from %s (%s): %s"), "DEL_EDGE", c->name,
-                          c->hostname, _("invalid name"));
-               return -1;
-       }
-
-       if(seen_request(c->buffer))
-               return 0;
+       if(seen_request(request))
+               return true;
 
        /* Lookup nodes */
 
        from = lookup_node(from_name);
+       to = lookup_node(to_name);
+
+       if(tunnelserver &&
+          from != myself && from != c->node &&
+          to != myself && to != c->node) {
+               /* ignore indirect edge registrations for tunnelserver */
+               logger(DEBUG_PROTOCOL, LOG_WARNING,
+                  "Ignoring indirect %s from %s (%s)",
+                  "DEL_EDGE", c->name, c->hostname);
+               return true;
+       }
 
        if(!from) {
-               ifdebug(PROTOCOL) logger(LOG_ERR, _("Got %s from %s (%s) which does not appear in the edge tree"),
+               logger(DEBUG_PROTOCOL, LOG_ERR, "Got %s from %s (%s) which does not appear in the edge tree",
                                   "DEL_EDGE", c->name, c->hostname);
-               return 0;
+               return true;
        }
 
-       to = lookup_node(to_name);
-
        if(!to) {
-               ifdebug(PROTOCOL) logger(LOG_ERR, _("Got %s from %s (%s) which does not appear in the edge tree"),
+               logger(DEBUG_PROTOCOL, LOG_ERR, "Got %s from %s (%s) which does not appear in the edge tree",
                                   "DEL_EDGE", c->name, c->hostname);
-               return 0;
+               return true;
        }
 
        /* Check if edge exists */
@@ -226,21 +284,23 @@ int del_edge_h(connection_t *c)
        e = lookup_edge(from, to);
 
        if(!e) {
-               ifdebug(PROTOCOL) logger(LOG_WARNING, _("Got %s from %s (%s) which does not appear in the edge tree"),
+               logger(DEBUG_PROTOCOL, LOG_WARNING, "Got %s from %s (%s) which does not appear in the edge tree",
                                   "DEL_EDGE", c->name, c->hostname);
-               return 0;
+               return true;
        }
 
        if(e->from == myself) {
-               ifdebug(PROTOCOL) logger(LOG_WARNING, _("Got %s from %s (%s) for ourself"),
+               logger(DEBUG_PROTOCOL, LOG_WARNING, "Got %s from %s (%s) for ourself",
                                   "DEL_EDGE", c->name, c->hostname);
-               send_add_edge(c, e);    /* Send back a correction */
-               return 0;
+               contradicting_del_edge++;
+               send_add_edge(c, e);    /* Send back a correction */
+               return true;
        }
 
        /* Tell the rest about the deleted edge */
 
-       forward_request(c);
+       if(!tunnelserver)
+               forward_request(c, request);
 
        /* Delete the edge */
 
@@ -250,5 +310,16 @@ int del_edge_h(connection_t *c)
 
        graph();
 
-       return 0;
+       /* If the node is not reachable anymore but we remember it had an edge to us, clean it up */
+
+       if(!to->status.reachable) {
+               e = lookup_edge(to, myself);
+               if(e) {
+                       if(!tunnelserver)
+                               send_del_edge(everyone, e);
+                       edge_del(e);
+               }
+       }
+
+       return true;
 }