tinc-gui: Reformat codebase according to PEP8
[tinc] / src / tincctl.c
index b36de76..abc5c09 100644 (file)
@@ -1,6 +1,6 @@
 /*
     tincctl.c -- Controlling a running tincd
-    Copyright (C) 2007-2014 Guus Sliepen <guus@tinc-vpn.org>
+    Copyright (C) 2007-2015 Guus Sliepen <guus@tinc-vpn.org>
 
     This program is free software; you can redistribute it and/or modify
     it under the terms of the GNU General Public License as published by
@@ -88,8 +88,8 @@ static struct option const long_options[] = {
 
 static void version(void) {
        printf("%s version %s (built %s %s, protocol %d.%d)\n", PACKAGE,
-                  VERSION, BUILD_DATE, BUILD_TIME, PROT_MAJOR, PROT_MINOR);
-       printf("Copyright (C) 1998-2014 Ivo Timmermans, Guus Sliepen and others.\n"
+                  BUILD_VERSION, BUILD_DATE, BUILD_TIME, PROT_MAJOR, PROT_MINOR);
+       printf("Copyright (C) 1998-2015 Ivo Timmermans, Guus Sliepen and others.\n"
                        "See the AUTHORS file for a complete list.\n\n"
                        "tinc comes with ABSOLUTELY NO WARRANTY.  This is free software,\n"
                        "and you are welcome to redistribute it under certain conditions;\n"
@@ -134,6 +134,7 @@ static void usage(bool status) {
                                "    subnets                  - all known subnets in the VPN\n"
                                "    connections              - all meta connections with ourself\n"
                                "    [di]graph                - graph of the VPN in dotty format\n"
+                               "    invitations              - outstanding invitations\n"
                                "  info NODE|SUBNET|ADDRESS   Give information about a particular NODE, SUBNET or ADDRESS.\n"
                                "  purge                      Purge unreachable nodes\n"
                                "  debug N                    Set debug level\n"
@@ -150,7 +151,7 @@ static void usage(bool status) {
                                "  exchange                   Same as export followed by import\n"
                                "  exchange-all               Same as export-all followed by import\n"
                                "  invite NODE [...]          Generate an invitation for NODE\n"
-                               "  join INVITATION            Join a VPN using an INVITIATION\n"
+                               "  join INVITATION            Join a VPN using an INVITATION\n"
                                "  network [NETNAME]          List all known networks, or switch to the one named NETNAME.\n"
                                "  fsck                       Check the configuration files for problems.\n"
                                "\n");
@@ -232,6 +233,12 @@ FILE *fopenmask(const char *filename, const char *mode, mode_t perms) {
        perms &= ~mask;
        umask(~perms);
        FILE *f = fopen(filename, mode);
+
+       if(!f) {
+               fprintf(stderr, "Could not open %s: %s\n", filename, strerror(errno));
+               return NULL;
+       }
+
 #ifdef HAVE_FCHMOD
        if((perms & 0444) && f)
                fchmod(fileno(f), perms);
@@ -375,7 +382,7 @@ static FILE *ask_and_open(const char *filename, const char *what, const char *mo
 static bool ed25519_keygen(bool ask) {
        ecdsa_t *key;
        FILE *f;
-       char *pubname, *privname;
+       char fname[PATH_MAX];
 
        fprintf(stderr, "Generating Ed25519 keypair:\n");
 
@@ -385,29 +392,25 @@ static bool ed25519_keygen(bool ask) {
        } else
                fprintf(stderr, "Done.\n");
 
-       xasprintf(&privname, "%s" SLASH "ed25519_key.priv", confbase);
-       f = ask_and_open(privname, "private Ed25519 key", "a", ask, 0600);
-       free(privname);
+       snprintf(fname, sizeof fname, "%s" SLASH "ed25519_key.priv", confbase);
+       f = ask_and_open(fname, "private Ed25519 key", "a", ask, 0600);
 
        if(!f)
-               return false;
+               goto error;
 
        if(!ecdsa_write_pem_private_key(key, f)) {
                fprintf(stderr, "Error writing private key!\n");
-               ecdsa_free(key);
-               fclose(f);
-               return false;
+               goto error;
        }
 
        fclose(f);
 
        if(name)
-               xasprintf(&pubname, "%s" SLASH "hosts" SLASH "%s", confbase, name);
+               snprintf(fname, sizeof fname, "%s" SLASH "hosts" SLASH "%s", confbase, name);
        else
-               xasprintf(&pubname, "%s" SLASH "ed25519_key.pub", confbase);
+               snprintf(fname, sizeof fname, "%s" SLASH "ed25519_key.pub", confbase);
 
-       f = ask_and_open(pubname, "public Ed25519 key", "a", ask, 0666);
-       free(pubname);
+       f = ask_and_open(fname, "public Ed25519 key", "a", ask, 0666);
 
        if(!f)
                return false;
@@ -420,6 +423,12 @@ static bool ed25519_keygen(bool ask) {
        ecdsa_free(key);
 
        return true;
+
+error:
+       if(f)
+               fclose(f);
+       ecdsa_free(key);
+       return false;
 }
 
 #ifndef DISABLE_LEGACY
@@ -430,7 +439,7 @@ static bool ed25519_keygen(bool ask) {
 static bool rsa_keygen(int bits, bool ask) {
        rsa_t *key;
        FILE *f;
-       char *pubname, *privname;
+       char fname[PATH_MAX];
 
        // Make sure the key size is a multiple of 8 bits.
        bits &= ~0x7;
@@ -449,44 +458,44 @@ static bool rsa_keygen(int bits, bool ask) {
        } else
                fprintf(stderr, "Done.\n");
 
-       xasprintf(&privname, "%s" SLASH "rsa_key.priv", confbase);
-       f = ask_and_open(privname, "private RSA key", "a", ask, 0600);
-       free(privname);
+       snprintf(fname, sizeof fname, "%s" SLASH "rsa_key.priv", confbase);
+       f = ask_and_open(fname, "private RSA key", "a", ask, 0600);
 
        if(!f)
-               return false;
+               goto error;
 
        if(!rsa_write_pem_private_key(key, f)) {
                fprintf(stderr, "Error writing private key!\n");
-               fclose(f);
-               rsa_free(key);
-               return false;
+               goto error;
        }
 
        fclose(f);
 
        if(name)
-               xasprintf(&pubname, "%s" SLASH "hosts" SLASH "%s", confbase, name);
+               snprintf(fname, sizeof fname, "%s" SLASH "hosts" SLASH "%s", confbase, name);
        else
-               xasprintf(&pubname, "%s" SLASH "rsa_key.pub", confbase);
+               snprintf(fname, sizeof fname, "%s" SLASH "rsa_key.pub", confbase);
 
-       f = ask_and_open(pubname, "public RSA key", "a", ask, 0666);
-       free(pubname);
+       f = ask_and_open(fname, "public RSA key", "a", ask, 0666);
 
        if(!f)
-               return false;
+               goto error;
 
        if(!rsa_write_pem_public_key(key, f)) {
                fprintf(stderr, "Error writing public key!\n");
-               fclose(f);
-               rsa_free(key);
-               return false;
+               goto error;
        }
 
        fclose(f);
        rsa_free(key);
 
        return true;
+
+error:
+       if(f)
+               fclose(f);
+       rsa_free(key);
+       return false;
 }
 #endif
 
@@ -851,6 +860,13 @@ static int cmd_start(int argc, char *argv[]) {
        }
        return status;
 #else
+       int pfd[2] = {-1, -1};
+       if(socketpair(AF_UNIX, SOCK_STREAM, 0, pfd)) {
+               fprintf(stderr, "Could not create umbilical socket: %s\n", strerror(errno));
+               free(nargv);
+               return 1;
+       }
+
        pid_t pid = fork();
        if(pid == -1) {
                fprintf(stderr, "Could not fork: %s\n", strerror(errno));
@@ -858,8 +874,15 @@ static int cmd_start(int argc, char *argv[]) {
                return 1;
        }
 
-       if(!pid)
+       if(!pid) {
+               close(pfd[0]);
+               char buf[100] = "";
+               snprintf(buf, sizeof buf, "%d", pfd[1]);
+               setenv("TINC_UMBILICAL", buf, true);
                exit(execvp(c, nargv));
+       } else {
+               close(pfd[1]);
+       }
 
        free(nargv);
 
@@ -867,12 +890,33 @@ static int cmd_start(int argc, char *argv[]) {
 #ifdef SIGINT
        signal(SIGINT, SIG_IGN);
 #endif
+
+       // Pass all log messages from the umbilical to stderr.
+       // A nul-byte right before closure means tincd started succesfully.
+       bool failure = true;
+       char buf[1024];
+       ssize_t len;
+
+       while((len = read(pfd[0], buf, sizeof buf)) > 0) {
+               failure = buf[len - 1];
+               if(!failure)
+                       len--;
+               write(2, buf, len);
+       }
+
+       if(len)
+               failure = true;
+
+       close(pfd[0]);
+
+       // Make sure the child process is really gone.
        result = waitpid(pid, &status, 0);
+
 #ifdef SIGINT
        signal(SIGINT, SIG_DFL);
 #endif
 
-       if(result != pid || !WIFEXITED(status) || WEXITSTATUS(status)) {
+       if(failure || result != pid || !WIFEXITED(status) || WEXITSTATUS(status)) {
                fprintf(stderr, "Error starting %s\n", c);
                return 1;
        }
@@ -943,6 +987,65 @@ static int cmd_reload(int argc, char *argv[]) {
 
 }
 
+static int dump_invitations(void) {
+       char dname[PATH_MAX];
+       snprintf(dname, sizeof dname, "%s" SLASH "invitations", confbase);
+       DIR *dir = opendir(dname);
+       if(!dir) {
+               if(errno == ENOENT) {
+                       fprintf(stderr, "No outstanding invitations.\n");
+                       return 0;
+               }
+
+               fprintf(stderr, "Cannot not read directory %s: %s\n", dname, strerror(errno));
+               return 1;
+       }
+
+       struct dirent *ent;
+       bool found = false;
+
+       while((ent = readdir(dir))) {
+               char buf[MAX_STRING_SIZE];
+               if(b64decode(ent->d_name, buf, 24) != 18)
+                       continue;
+
+               char fname[PATH_MAX];
+               snprintf(fname, sizeof fname, "%s" SLASH "%s", dname, ent->d_name);
+               FILE *f = fopen(fname, "r");
+               if(!f) {
+                       fprintf(stderr, "Cannot open %s: %s\n", fname, strerror(errno));
+                       fclose(f);
+                       continue;
+               }
+
+               buf[0] = 0;
+               if(!fgets(buf, sizeof buf, f)) {
+                       fprintf(stderr, "Invalid invitation file %s", fname);
+                       fclose(f);
+                       continue;
+               }
+               fclose(f);
+
+               char *eol = buf + strlen(buf);
+               while(strchr("\t \r\n", *--eol))
+                       *eol = 0;
+               if(strncmp(buf, "Name = ", 7) || !check_id(buf + 7)) {
+                       fprintf(stderr, "Invalid invitation file %s", fname);
+                       continue;
+               }
+
+               found = true;
+               printf("%s %s\n", ent->d_name, buf + 7);
+       }
+
+       closedir(dir);
+
+       if(!found)
+               fprintf(stderr, "No outstanding invitations.\n");
+
+       return 0;
+}
+
 static int cmd_dump(int argc, char *argv[]) {
        bool only_reachable = false;
 
@@ -963,6 +1066,9 @@ static int cmd_dump(int argc, char *argv[]) {
                return 1;
        }
 
+       if(!strcasecmp(argv[1], "invitations"))
+               return dump_invitations();
+
        if(!connect_tincd(true))
                return 1;
 
@@ -1371,6 +1477,8 @@ const var_t variables[] = {
        {"UDPDiscoveryKeepaliveInterval", VAR_SERVER},
        {"UDPDiscoveryInterval", VAR_SERVER},
        {"UDPDiscoveryTimeout", VAR_SERVER},
+       {"MTUInfoInterval", VAR_SERVER},
+       {"UDPInfoInterval", VAR_SERVER},
        {"UDPRcvBuf", VAR_SERVER},
        {"UDPSndBuf", VAR_SERVER},
        {"VDEGroup", VAR_SERVER},
@@ -1532,11 +1640,11 @@ static int cmd_config(int argc, char *argv[]) {
        }
 
        // Open the right configuration file.
-       char *filename;
+       char filename[PATH_MAX];
        if(node)
-               xasprintf(&filename, "%s" SLASH "%s", hosts_dir, node);
+               snprintf(filename, sizeof filename, "%s" SLASH "%s", hosts_dir, node);
        else
-               filename = tinc_conf;
+               snprintf(filename, sizeof filename, "%s", tinc_conf);
 
        FILE *f = fopen(filename, "r");
        if(!f) {
@@ -1544,11 +1652,11 @@ static int cmd_config(int argc, char *argv[]) {
                return 1;
        }
 
-       char *tmpfile = NULL;
+       char tmpfile[PATH_MAX];
        FILE *tf = NULL;
 
        if(action >= -1) {
-               xasprintf(&tmpfile, "%s.config.tmp", filename);
+               snprintf(tmpfile, sizeof tmpfile, "%s.config.tmp", filename);
                tf = fopen(tmpfile, "w");
                if(!tf) {
                        fprintf(stderr, "Could not open temporary file %s: %s\n", tmpfile, strerror(errno));
@@ -1697,7 +1805,7 @@ static int cmd_config(int argc, char *argv[]) {
 }
 
 static bool try_bind(int port) {
-       struct addrinfo *ai = NULL;
+       struct addrinfo *ai = NULL, *aip;
        struct addrinfo hint = {
                .ai_flags = AI_PASSIVE,
                .ai_family = AF_UNSPEC,
@@ -1705,24 +1813,30 @@ static bool try_bind(int port) {
                .ai_protocol = IPPROTO_TCP,
        };
 
+       bool success = true;
        char portstr[16];
        snprintf(portstr, sizeof portstr, "%d", port);
 
        if(getaddrinfo(NULL, portstr, &hint, &ai) || !ai)
                return false;
 
-       while(ai) {
+       for(aip = ai; aip; aip = aip->ai_next) {
                int fd = socket(ai->ai_family, SOCK_STREAM, IPPROTO_TCP);
-               if(!fd)
-                       return false;
+               if(!fd) {
+                       success = false;
+                       break;
+               }
+
                int result = bind(fd, ai->ai_addr, ai->ai_addrlen);
                closesocket(fd);
-               if(result)
-                       return false;
-               ai = ai->ai_next;
+               if(result) {
+                       success = false;
+                       break;
+               }
        }
 
-       return true;
+       freeaddrinfo(ai);
+       return success;
 }
 
 int check_port(char *name) {
@@ -1734,11 +1848,11 @@ int check_port(char *name) {
        for(int i = 0; i < 100; i++) {
                int port = 0x1000 + (rand() & 0x7fff);
                if(try_bind(port)) {
-                       char *filename;
-                       xasprintf(&filename, "%s" SLASH "hosts" SLASH "%s", confbase, name);
+                       char filename[PATH_MAX];
+                       snprintf(filename, sizeof filename, "%s" SLASH "hosts" SLASH "%s", confbase, name);
                        FILE *f = fopen(filename, "a");
-                       free(filename);
                        if(!f) {
+                               fprintf(stderr, "Could not open %s: %s\n", filename, strerror(errno));
                                fprintf(stderr, "Please change tinc's Port manually.\n");
                                return 0;
                        }
@@ -1829,8 +1943,8 @@ static int cmd_init(int argc, char *argv[]) {
        check_port(name);
 
 #ifndef HAVE_MINGW
-       char *filename;
-       xasprintf(&filename, "%s" SLASH "tinc-up", confbase);
+       char filename[PATH_MAX];
+       snprintf(filename, sizeof filename, "%s" SLASH "tinc-up", confbase);
        if(access(filename, F_OK)) {
                FILE *f = fopenmask(filename, "w", 0777);
                if(!f) {
@@ -1940,12 +2054,12 @@ static int cmd_edit(int argc, char *argv[]) {
                return 1;
        }
 
-       char *filename = NULL;
+       char filename[PATH_MAX] = "";
 
        if(strncmp(argv[1], "hosts" SLASH, 6)) {
                for(int i = 0; conffiles[i]; i++) {
                        if(!strcmp(argv[1], conffiles[i])) {
-                               xasprintf(&filename, "%s" SLASH "%s", confbase, argv[1]);
+                               snprintf(filename, sizeof filename, "%s" SLASH "%s", confbase, argv[1]);
                                break;
                        }
                }
@@ -1953,8 +2067,8 @@ static int cmd_edit(int argc, char *argv[]) {
                argv[1] += 6;
        }
 
-       if(!filename) {
-               xasprintf(&filename, "%s" SLASH "%s", hosts_dir, argv[1]);
+       if(!*filename) {
+               snprintf(filename, sizeof filename, "%s" SLASH "%s", hosts_dir, argv[1]);
                char *dash = strchr(argv[1], '-');
                if(dash) {
                        *dash++ = 0;
@@ -1972,6 +2086,7 @@ static int cmd_edit(int argc, char *argv[]) {
        xasprintf(&command, "edit \"%s\"", filename);
 #endif
        int result = system(command);
+       free(command);
        if(result)
                return result;
 
@@ -1983,8 +2098,8 @@ static int cmd_edit(int argc, char *argv[]) {
 }
 
 static int export(const char *name, FILE *out) {
-       char *filename;
-       xasprintf(&filename, "%s" SLASH "%s", hosts_dir, name);
+       char filename[PATH_MAX];
+       snprintf(filename, sizeof filename, "%s" SLASH "%s", hosts_dir, name);
        FILE *in = fopen(filename, "r");
        if(!in) {
                fprintf(stderr, "Could not open configuration file %s: %s\n", filename, strerror(errno));
@@ -2071,7 +2186,7 @@ static int cmd_import(int argc, char *argv[]) {
 
        char buf[4096];
        char name[4096];
-       char *filename = NULL;
+       char filename[PATH_MAX] = "";
        int count = 0;
        bool firstline = true;
 
@@ -2087,8 +2202,7 @@ static int cmd_import(int argc, char *argv[]) {
                        if(out)
                                fclose(out);
 
-                       free(filename);
-                       xasprintf(&filename, "%s" SLASH "%s", hosts_dir, name);
+                       snprintf(filename, sizeof filename, "%s" SLASH "%s", hosts_dir, name);
 
                        if(!force && !access(filename, F_OK)) {
                                fprintf(stderr, "Host configuration file %s already exists, skipping.\n", filename);
@@ -2194,11 +2308,10 @@ static int cmd_network(int argc, char *argv[]) {
                        continue;
                }
 
-               char *fname;
-               xasprintf(&fname, "%s/%s/tinc.conf", confdir, ent->d_name);
+               char fname[PATH_MAX];
+               snprintf(fname, sizeof fname, "%s/%s/tinc.conf", confdir, ent->d_name);
                if(!access(fname, R_OK))
                        printf("%s\n", ent->d_name);
-               free(fname);
        }
 
        closedir(dir);
@@ -2225,6 +2338,7 @@ static const struct {
        {"restart", cmd_restart},
        {"reload", cmd_reload},
        {"dump", cmd_dump},
+       {"list", cmd_dump},
        {"purge", cmd_purge},
        {"debug", cmd_debug},
        {"retry", cmd_retry},
@@ -2492,7 +2606,7 @@ int main(int argc, char *argv[]) {
        if(!parse_options(argc, argv))
                return 1;
 
-       make_names();
+       make_names(false);
        xasprintf(&tinc_conf, "%s" SLASH "tinc.conf", confbase);
        xasprintf(&hosts_dir, "%s" SLASH "hosts", confbase);