Comment out old public/private keys when generating new ones.
[tinc] / src / tincctl.c
index 3b0c614..eaf676d 100644 (file)
@@ -44,6 +44,9 @@
 /* The name this program was run with. */
 static char *program_name = NULL;
 
+static char **orig_argv;
+static int orig_argc;
+
 /* If nonzero, display usage information and exit. */
 static bool show_help = false;
 
@@ -135,7 +138,7 @@ static void usage(bool status) {
                                "    edges                    - all known connections in the VPN\n"
                                "    subnets                  - all known subnets in the VPN\n"
                                "    connections              - all meta connections with ourself\n"
-                               "    graph                    - graph of the VPN in dotty format\n"
+                               "    [di]graph                - graph of the VPN in dotty format\n"
                                "  info NODE|SUBNET|ADDRESS   Give information about a particular NODE, SUBNET or ADDRESS.\n"
                                "  purge                      Purge unreachable nodes\n"
                                "  debug N                    Set debug level\n"
@@ -214,6 +217,83 @@ static bool parse_options(int argc, char **argv) {
        return true;
 }
 
+static void disable_old_keys(const char *filename, const char *what) {
+       char tmpfile[PATH_MAX] = "";
+       char buf[1024];
+       bool disabled = false;
+       bool block = false;
+       bool error = false;
+       FILE *r, *w;
+
+       r = fopen(filename, "r");
+       if(!r)
+               return;
+
+       snprintf(tmpfile, sizeof tmpfile, "%s.tmp", filename);
+
+       w = fopen(tmpfile, "w");
+
+       while(fgets(buf, sizeof buf, r)) {
+               if(!block && !strncmp(buf, "-----BEGIN ", 11)) {
+                       if((strstr(buf, " EC ") && strstr(what, "ECDSA")) || (strstr(buf, " RSA ") && strstr(what, "RSA"))) {
+                               disabled = true;
+                               block = true;
+                       }
+               }
+
+               bool ecdsapubkey = !strncasecmp(buf, "ECDSAPublicKey", 14) && strchr(" \t=", buf[14]) && strstr(what, "ECDSA");
+
+               if(ecdsapubkey)
+                       disabled = true;
+
+               if(w) {
+                       if(block || ecdsapubkey)
+                               fputc('#', w);
+                       if(fputs(buf, w) < 0) {
+                               error = true;
+                               break;
+                       }
+               }
+
+               if(block && !strncmp(buf, "-----END ", 9))
+                       block = false;
+       }
+
+       if(w)
+               if(fclose(w) < 0)
+                       error = true;
+       if(ferror(r) || fclose(r) < 0)
+               error = true;
+
+       if(disabled) {
+               if(!w || error) {
+                       fprintf(stderr, "Warning: old key(s) found, remove them by hand!\n");
+                       if(w)
+                               unlink(tmpfile);
+                       return;
+               }
+
+#ifdef HAVE_MINGW
+               // We cannot atomically replace files on Windows.
+               char bakfile[PATH_MAX] = "";
+               snprintf(bakfile, sizeof bakfile, "%s.bak", filename);
+               if(rename(filename, bakfile) || rename(tmpfile, filename)) {
+                       rename(bakfile, filename);
+#else
+               if(rename(tmpfile, filename)) {
+#endif
+                       fprintf(stderr, "Warning: old key(s) found, remove them by hand!\n");
+               } else  {
+#ifdef HAVE_MINGW
+                       unlink(bakfile);
+#endif
+                       fprintf(stderr, "Warning: old key(s) found and disabled.\n");
+               }
+       }
+
+       unlink(tmpfile);
+}
+
 static FILE *ask_and_open(const char *filename, const char *what, const char *mode, bool ask) {
        FILE *r;
        char *directory;
@@ -254,6 +334,8 @@ static FILE *ask_and_open(const char *filename, const char *what, const char *mo
 
        umask(0077);                            /* Disallow everything for group and other */
 
+       disable_old_keys(filename, what);
+
        /* Open it first to keep the inode busy */
 
        r = fopen(filename, mode);
@@ -294,9 +376,6 @@ static bool ecdsa_keygen(bool ask) {
        fchmod(fileno(f), 0600);
 #endif
                
-       if(ftell(f))
-               fprintf(stderr, "Appending key to existing contents.\nMake sure only one key is stored in the file.\n");
-
        ecdsa_write_pem_private_key(&key, f);
 
        fclose(f);
@@ -312,9 +391,6 @@ static bool ecdsa_keygen(bool ask) {
        if(!f)
                return false;
 
-       if(ftell(f))
-               fprintf(stderr, "Appending key to existing contents.\nMake sure only one key is stored in the file.\n");
-
        char *pubkey = ecdsa_get_base64_public_key(&key);
        fprintf(f, "ECDSAPublicKey = %s\n", pubkey);
        free(pubkey);
@@ -353,9 +429,6 @@ static bool rsa_keygen(int bits, bool ask) {
        fchmod(fileno(f), 0600);
 #endif
                
-       if(ftell(f))
-               fprintf(stderr, "Appending key to existing contents.\nMake sure only one key is stored in the file.\n");
-
        rsa_write_pem_private_key(&key, f);
 
        fclose(f);
@@ -371,9 +444,6 @@ static bool rsa_keygen(int bits, bool ask) {
        if(!f)
                return false;
 
-       if(ftell(f))
-               fprintf(stderr, "Appending key to existing contents.\nMake sure only one key is stored in the file.\n");
-
        rsa_write_pem_public_key(&key, f);
 
        fclose(f);
@@ -708,33 +778,57 @@ static bool connect_tincd(bool verbose) {
 
 
 static int cmd_start(int argc, char *argv[]) {
-       int i, j;
-       char *c;
+       if(connect_tincd(false)) {
+               if(netname)
+                       fprintf(stderr, "A tincd is already running for net `%s' with pid %d.\n", netname, pid);
+               else
+                       fprintf(stderr, "A tincd is already running with pid %d.\n", pid);
+               return 0;
+       }
 
-       argc += optind;
-       argv -= optind;
-       char *slash = strrchr(argv[0], '/');
+       char *c;
+       char *slash = strrchr(program_name, '/');
 
 #ifdef HAVE_MINGW
-       if ((c = strrchr(argv[0], '\\')) > slash)
+       if ((c = strrchr(program_name, '\\')) > slash)
                slash = c;
 #endif
 
        if (slash++)
-               xasprintf(&c, "%.*stincd", (int)(slash - argv[0]), argv[0]);
+               xasprintf(&c, "%.*stincd", (int)(slash - program_name), program_name);
        else
                c = "tincd";
 
-       argv[0] = c;
+       int nargc = 0;
+       char **nargv = xmalloc_and_zero((orig_argc + argc) * sizeof *nargv);
 
-       for(i = j = 1; argv[i]; ++i)
-               if (i != optind && strcmp(argv[i], "--") != 0)
-                       argv[j++] = argv[i];
+       for(int i = 0; i < orig_argc; i++)
+               nargv[nargc++] = orig_argv[i];
+       for(int i = 1; i < argc; i++)
+               nargv[nargc++] = argv[i];
 
-       argv[j] = NULL;
-       execvp(c, argv);
-       fprintf(stderr, "Could not start %s: %s\n", c, strerror(errno));
+#ifdef HAVE_MINGW
+       execvp(c, nargv);
+       fprintf(stderr, "Error starting %s: %s\n", c, strerror(errno));
        return 1;
+#else
+       pid_t pid = fork();
+       if(pid == -1) {
+               fprintf(stderr, "Could not fork: %s\n", strerror(errno));
+               return 1;
+       }
+
+       if(!pid)
+               exit(execvp(c, nargv));
+       
+       int status = -1;
+       if(waitpid(pid, &status, 0) != pid || !WIFEXITED(status) || WEXITSTATUS(status)) {
+               fprintf(stderr, "Error starting %s\n", c);
+               return 1;
+       }
+
+       return 0;
+#endif
 }
 
 static int cmd_stop(int argc, char *argv[]) {
@@ -759,6 +853,10 @@ static int cmd_stop(int argc, char *argv[]) {
        if(!remove_service())
                return 1;
 #endif
+       close(fd);
+       pid = 0;
+       fd = -1;
+
        return 0;
 }
 
@@ -791,7 +889,7 @@ static int cmd_dump(int argc, char *argv[]) {
        if(!connect_tincd(true))
                return 1;
 
-       bool do_graph = false;
+       int do_graph = 0;
 
        if(!strcasecmp(argv[1], "nodes"))
                sendline(fd, "%d %d", CONTROL, REQ_DUMP_NODES);
@@ -804,19 +902,25 @@ static int cmd_dump(int argc, char *argv[]) {
        else if(!strcasecmp(argv[1], "graph")) {
                sendline(fd, "%d %d", CONTROL, REQ_DUMP_NODES);
                sendline(fd, "%d %d", CONTROL, REQ_DUMP_EDGES);
-               do_graph = true;
+               do_graph = 1;
+       } else if(!strcasecmp(argv[1], "digraph")) {
+               sendline(fd, "%d %d", CONTROL, REQ_DUMP_NODES);
+               sendline(fd, "%d %d", CONTROL, REQ_DUMP_EDGES);
+               do_graph = 2;
        } else {
                fprintf(stderr, "Unknown dump type '%s'.\n", argv[1]);
                usage(true);
                return 1;
        }
 
-       if(do_graph)
+       if(do_graph == 1)
+               printf("graph {\n");
+       else if(do_graph == 2)
                printf("digraph {\n");
 
        while(recvline(fd, line, sizeof line)) {
                char node1[4096], node2[4096];
-               int n = sscanf(line, "%d %d %s to %s", &code, &req, node1, node2);
+               int n = sscanf(line, "%d %d %s %s", &code, &req, node1, node2);
                if(n == 2) {
                        if(do_graph && req == REQ_DUMP_NODES)
                                continue;
@@ -829,13 +933,71 @@ static int cmd_dump(int argc, char *argv[]) {
                if(n < 2)
                        break;
 
-               if(!do_graph)
-                       printf("%s\n", line + 5);
-               else {
+               if(!do_graph) {
+                       char node[4096];
+                       char from[4096];
+                       char to[4096];
+                       char subnet[4096];
+                       char host[4096];
+                       char port[4096];
+                       char via[4096];
+                       char nexthop[4096];
+                       int cipher, digest, maclength, compression, distance, socket, weight;
+                       short int pmtu, minmtu, maxmtu;
+                       unsigned int options, status;
+                       long int last_state_change;
+
+                       switch(req) {
+                               case REQ_DUMP_NODES: {
+                                       int n = sscanf(line, "%*d %*d %s %s port %s %d %d %d %d %x %x %s %s %d %hd %hd %hd %ld", node, host, port, &cipher, &digest, &maclength, &compression, &options, &status, nexthop, via, &distance, &pmtu, &minmtu, &maxmtu, &last_state_change);
+                                       if(n != 16) {
+                                               fprintf(stderr, "Unable to parse node dump from tincd: %s\n", line);
+                                               return 1;
+                                       }
+                                       printf("%s at %s port %s cipher %d digest %d maclength %d compression %d options %x status %04x nexthop %s via %s distance %d pmtu %hd (min %hd max %hd)\n",
+                                                       node, host, port, cipher, digest, maclength, compression, options, status, nexthop, via, distance, pmtu, minmtu, maxmtu);
+                               } break;
+
+                               case REQ_DUMP_EDGES: {
+                                       int n = sscanf(line, "%*d %*d %s %s %s port %s %x %d", from, to, host, port, &options, &weight);
+                                       if(n != 6) {
+                                               fprintf(stderr, "Unable to parse edge dump from tincd.\n");
+                                               return 1;
+                                       }
+                                       printf("%s to %s at %s port %s options %x weight %d\n", from, to, host, port, options, weight);
+                               } break;
+
+                               case REQ_DUMP_SUBNETS: {
+                                       int n = sscanf(line, "%*d %*d %s %s", subnet, node);
+                                       if(n != 2) {
+                                               fprintf(stderr, "Unable to parse subnet dump from tincd.\n");
+                                               return 1;
+                                       }
+                                       printf("%s owner %s\n", strip_weight(subnet), node);
+                               } break;
+
+                               case REQ_DUMP_CONNECTIONS: {
+                                       int n = sscanf(line, "%*d %*d %s %s port %s %x %d %x", node, host, port, &options, &socket, &status);
+                                       if(n != 6) {
+                                               fprintf(stderr, "Unable to parse connection dump from tincd.\n");
+                                               return 1;
+                                       }
+                                       printf("%s at %s port %s options %x socket %d status %x\n", node, host, port, options, socket, status);
+                               } break;
+
+                               default:
+                                       fprintf(stderr, "Unable to parse dump from tincd.\n");
+                                       return 1;
+                       }
+               } else {
                        if(req == REQ_DUMP_NODES)
                                printf(" %s [label = \"%s\"];\n", node1, node1);
-                       else
-                               printf(" %s -> %s;\n", node1, node2);
+                       else {
+                               if(do_graph == 1 && strcmp(node1, node2) > 0)
+                                       printf(" %s -- %s;\n", node1, node2);
+                               else if(do_graph == 2)
+                                       printf(" %s -> %s;\n", node1, node2);
+                       }
                }
        }
 
@@ -897,7 +1059,7 @@ static int cmd_connect(int argc, char *argv[]) {
                return 1;
        }
 
-       if(!check_id(argv[2])) {
+       if(!check_id(argv[1])) {
                fprintf(stderr, "Invalid name for node.\n");
                return 1;
        }
@@ -920,7 +1082,7 @@ static int cmd_disconnect(int argc, char *argv[]) {
                return 1;
        }
 
-       if(!check_id(argv[2])) {
+       if(!check_id(argv[1])) {
                fprintf(stderr, "Invalid name for node.\n");
                return 1;
        }
@@ -1752,6 +1914,88 @@ static char *complete_dump(const char *text, int state) {
        return NULL;
 }
 
+static char *complete_config(const char *text, int state) {
+       const char *sub[] = {"get", "set", "add", "del"};
+       static int i;
+       if(!state) {
+               i = 0;
+               if(!strchr(rl_line_buffer + 7, ' '))
+                       i = -4;
+               else {
+                       bool found = false;
+                       for(int i = 0; i < 4; i++) {
+                               if(!strncasecmp(rl_line_buffer + 7, sub[i], strlen(sub[i])) && rl_line_buffer[7 + strlen(sub[i])] == ' ') {
+                                       found = true;
+                                       break;
+                               }
+                       }
+                       if(!found)
+                               return NULL;
+               }
+       } else {
+               i++;
+       }
+
+       while(i < 0 || variables[i].name) {
+               if(i < 0 && !strncasecmp(sub[i + 4], text, strlen(text)))
+                       return xstrdup(sub[i + 4]);
+               if(i >= 0) {
+                       char *dot = strchr(text, '.');
+                       if(dot) {
+                               if((variables[i].type & VAR_HOST) && !strncasecmp(variables[i].name, dot + 1, strlen(dot + 1))) {
+                                       char *match;
+                                       xasprintf(&match, "%.*s.%s", dot - text, text, variables[i].name);
+                                       return match;
+                               }
+                       } else {
+                               if(!strncasecmp(variables[i].name, text, strlen(text)))
+                                       return xstrdup(variables[i].name);
+                       }
+               }
+               i++;
+       }
+
+       return NULL;
+}
+
+static char *complete_info(const char *text, int state) {
+       static int i;
+       if(!state) {
+               i = 0;
+               if(!connect_tincd(false))
+                       return NULL;
+               // Check the list of nodes
+               sendline(fd, "%d %d", CONTROL, REQ_DUMP_NODES);
+               sendline(fd, "%d %d", CONTROL, REQ_DUMP_SUBNETS);
+       }
+
+       while(recvline(fd, line, sizeof line)) {
+               char item[4096];
+               int n = sscanf(line, "%d %d %s", &code, &req, item);
+               if(n == 2) {
+                       i++;
+                       if(i >= 2)
+                               break;
+                       else
+                               continue;
+               }
+
+               if(n != 3) {
+                       fprintf(stderr, "Unable to parse dump from tincd, n = %d, i = %d.\n", n, i);
+                       break;
+               }
+
+               if(!strncmp(item, text, strlen(text)))
+                       return xstrdup(strip_weight(item));
+       }
+
+       return NULL;
+}
+
+static char *complete_nothing(const char *text, int state) {
+       return NULL;
+}
+
 static char **completion (const char *text, int start, int end) {
        char **matches = NULL;
 
@@ -1759,6 +2003,10 @@ static char **completion (const char *text, int start, int end) {
                matches = rl_completion_matches(text, complete_command);
        else if(!strncasecmp(rl_line_buffer, "dump ", 5))
                matches = rl_completion_matches(text, complete_dump);
+       else if(!strncasecmp(rl_line_buffer, "config ", 7))
+               matches = rl_completion_matches(text, complete_config);
+       else if(!strncasecmp(rl_line_buffer, "info ", 5))
+               matches = rl_completion_matches(text, complete_info);
 
        return matches;
 }
@@ -1779,6 +2027,7 @@ static int cmd_shell(int argc, char *argv[]) {
 
 #ifdef HAVE_READLINE
        rl_readline_name = "tinc";
+       rl_completion_entry_function = complete_nothing;
        rl_attempted_completion_function = completion;
        rl_filename_completion_desired = 0;
        char *copy = NULL;
@@ -1789,6 +2038,7 @@ static int cmd_shell(int argc, char *argv[]) {
                if(tty) {
                        free(copy);
                        free(line);
+                       rl_basic_word_break_characters = "\t\n ";
                        line = readline(prompt);
                        if(line)
                                copy = xstrdup(line);
@@ -1797,7 +2047,7 @@ static int cmd_shell(int argc, char *argv[]) {
                }
 #else
                if(tty)
-                       fputs(stdout, prompt);
+                       fputs(prompt, stdout);
 
                line = fgets(buf, sizeof buf, stdin);
 #endif
@@ -1832,6 +2082,9 @@ static int cmd_shell(int argc, char *argv[]) {
                if(nargc == argc)
                        continue;
 
+               if(!strcasecmp(nargv[argc], "exit") || !strcasecmp(nargv[argc], "quit"))
+                       return result;
+
                bool found = false;
 
                for(int i = 0; commands[i].command; i++) {
@@ -1843,7 +2096,7 @@ static int cmd_shell(int argc, char *argv[]) {
                }
 
 #ifdef HAVE_READLINE
-               if(found)
+               if(tty && found)
                        add_history(copy);
 #endif
 
@@ -1861,6 +2114,8 @@ static int cmd_shell(int argc, char *argv[]) {
 
 int main(int argc, char *argv[]) {
        program_name = argv[0];
+       orig_argv = argv;
+       orig_argc = argc;
 
        if(!parse_options(argc, argv))
                return 1;