Reduce pointer indirection for global list_t variables

[tinc] / src / tincd.c

diff --git a/src/tincd.c b/src/tincd.c
index 35a84be..dee38ef 100644 (file)
--- a/src/tincd.c
+++ b/src/tincd.c
@@ -148,8 +148,6 @@ static bool parse_options(int argc, char **argv) {
        int option_index = 0;
        int lineno = 0;
 
-       cmdline_conf = list_alloc((list_action_t)free_config);
-
        while((r = getopt_long(argc, argv, "c:DLd::n:so:RU:", long_options, &option_index)) != EOF) {
                switch(r) {
                case 0:   /* long option */
@@ -203,7 +201,7 @@ static bool parse_options(int argc, char **argv) {
                                goto exit_fail;
                        }
 
-                       list_insert_tail(cmdline_conf, cfg);
+                       list_insert_tail(&cmdline_conf, cfg);
                        break;
 
 #ifdef HAVE_MINGW
@@ -294,8 +292,7 @@ static bool parse_options(int argc, char **argv) {
 
 exit_fail:
        free_names();
-       list_delete_list(cmdline_conf);
-       cmdline_conf = NULL;
+       list_empty_list(&cmdline_conf);
        return false;
 }
 
@@ -313,7 +310,9 @@ static bool drop_privs(void) {
 
                uid = pw->pw_uid;
 
-               if(initgroups(switchuser, pw->pw_gid) != 0 ||
+               // The second parameter to initgroups on macOS requires int,
+               // but __gid_t is unsigned int. There's not much we can do here.
+               if(initgroups(switchuser, pw->pw_gid) != 0 || // NOLINT(bugprone-narrowing-conversions)
                                setgid(pw->pw_gid) != 0) {
                        logger(DEBUG_ALWAYS, LOG_ERR, "System call `%s' failed: %s",
                               "initgroups", strerror(errno));
@@ -384,7 +383,7 @@ static void cleanup() {
                exit_configuration(&config_tree);
        }
 
-       list_delete_list(cmdline_conf);
+       list_empty_list(&cmdline_conf);
        free_names();
 }
 
@@ -505,8 +504,12 @@ int main(int argc, char **argv) {
                return 1;
        }
 
-       if(!debug_level) {
-               get_config_int(lookup_config(config_tree, "LogLevel"), &debug_level);
+       if(debug_level == DEBUG_NOTHING) {
+               int level = 0;
+
+               if(get_config_int(lookup_config(config_tree, "LogLevel"), &level)) {
+                       debug_level = level;
+               }
        }
 
 #ifdef HAVE_LZO