X-Git-Url: https://tinc-vpn.org/git/browse?p=tinc;a=blobdiff_plain;f=src%2Fmeta.c;h=0e4b0d2290e0ad6c619458e2f5a846b849c300d6;hp=0025dd83e01c23a88eaca1bd79173609c0bb3c3f;hb=f4e80cc5e0d1689bcdd828ac7f158bd634b7dd20;hpb=161f917dd03c174742fb8c6722f430a93b506cb1

diff --git a/src/meta.c b/src/meta.c
index 0025dd83..0e4b0d22 100644
--- a/src/meta.c
+++ b/src/meta.c
@@ -1,7 +1,7 @@
 /*
     meta.c -- handle the meta communication
-    Copyright (C) 2000-2002 Guus Sliepen <guus@sliepen.eu.org>,
-                  2000-2002 Ivo Timmermans <ivo@o2w.nl>
+    Copyright (C) 2000-2003 Guus Sliepen <guus@sliepen.eu.org>,
+                  2000-2003 Ivo Timmermans <ivo@o2w.nl>
 
     This program is free software; you can redistribute it and/or modify
     it under the terms of the GNU General Public License as published by
@@ -17,38 +17,32 @@
     along with this program; if not, write to the Free Software
     Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
 
-    $Id: meta.c,v 1.1.2.31 2002/09/10 09:40:25 guus Exp $
+    $Id: meta.c,v 1.1.2.42 2003/08/16 12:40:00 guus Exp $
 */
 
-#include "config.h"
-#include <utils.h>
-#include <avl_tree.h>
-
-#include <errno.h>
-#include <syslog.h>
-#include <unistd.h>
-#include <string.h>
-/* This line must be below the rest for FreeBSD */
-#include <sys/types.h>
-#include <sys/socket.h>
+#include "system.h"
 
 #include <openssl/evp.h>
 
-#include "net.h"
+#include "avl_tree.h"
 #include "connection.h"
-#include "system.h"
+#include "logger.h"
+#include "meta.h"
+#include "net.h"
 #include "protocol.h"
+#include "system.h"
+#include "utils.h"
 
-int send_meta(connection_t *c, char *buffer, int length)
+bool send_meta(connection_t *c, const char *buffer, int length)
 {
-	char *bufp;
+	const char *bufp;
 	int outlen;
 	char outbuf[MAXBUFSIZE];
+	int result;
 
 	cp();
 
-	if(debug_lvl >= DEBUG_META)
-		syslog(LOG_DEBUG, _("Sending %d bytes of metadata to %s (%s)"), length,
+	ifdebug(META) logger(LOG_DEBUG, _("Sending %d bytes of metadata to %s (%s)"), length,
 			   c->name, c->hostname);
 
 	if(c->status.encryptout) {
@@ -58,16 +52,27 @@ int send_meta(connection_t *c, char *buffer, int length)
 	} else
 		bufp = buffer;
 
-	if(write(c->socket, bufp, length) < 0) {
-		syslog(LOG_ERR, _("Sending meta data to %s (%s) failed: %s"), c->name,
-			   c->hostname, strerror(errno));
-		return -1;
+	while(length) {
+		result = send(c->socket, bufp, length, 0);
+		if(result <= 0) {
+			if(!errno || errno == EPIPE) {
+				ifdebug(CONNECTIONS) logger(LOG_NOTICE, _("Connection closed by %s (%s)"),
+						   c->name, c->hostname);
+			} else if(errno == EINTR)
+				continue;
+			else
+				logger(LOG_ERR, _("Sending meta data to %s (%s) failed: %s"), c->name,
+					   c->hostname, strerror(errno));
+			return false;
+		}
+		bufp += result;
+		length -= result;
 	}
-
-	return 0;
+	
+	return true;
 }
 
-void broadcast_meta(connection_t *from, char *buffer, int length)
+void broadcast_meta(connection_t *from, const char *buffer, int length)
 {
 	avl_node_t *node;
 	connection_t *c;
@@ -82,29 +87,17 @@ void broadcast_meta(connection_t *from, char *buffer, int length)
 	}
 }
 
-int receive_meta(connection_t *c)
+bool receive_meta(connection_t *c)
 {
 	int x;
 	socklen_t l = sizeof(x);
 	int oldlen, i;
 	int lenin, reqlen;
-	int decrypted = 0;
+	bool decrypted = false;
 	char inbuf[MAXBUFSIZE];
 
 	cp();
 
-	if(getsockopt(c->socket, SOL_SOCKET, SO_ERROR, &x, &l) < 0) {
-		syslog(LOG_ERR, _("This is a bug: %s:%d: %d:%s %s (%s)"), __FILE__,
-			   __LINE__, c->socket, strerror(errno), c->name, c->hostname);
-		return -1;
-	}
-
-	if(x) {
-		syslog(LOG_ERR, _("Metadata socket error for %s (%s): %s"),
-			   c->name, c->hostname, strerror(x));
-		return -1;
-	}
-
 	/* Strategy:
 	   - Read as much as possible from the TCP socket in one go.
 	   - Decrypt it.
@@ -114,20 +107,19 @@ int receive_meta(connection_t *c)
 	   - If not, keep stuff in buffer and exit.
 	 */
 
-	lenin = read(c->socket, c->buffer + c->buflen, MAXBUFSIZE - c->buflen);
+	lenin = recv(c->socket, c->buffer + c->buflen, MAXBUFSIZE - c->buflen, 0);
 
 	if(lenin <= 0) {
-		if(lenin == 0) {
-			if(debug_lvl >= DEBUG_CONNECTIONS)
-				syslog(LOG_NOTICE, _("Connection closed by %s (%s)"),
+		if(!lenin || !errno) {
+			ifdebug(CONNECTIONS) logger(LOG_NOTICE, _("Connection closed by %s (%s)"),
 					   c->name, c->hostname);
 		} else if(errno == EINTR)
-			return 0;
+			return true;
 		else
-			syslog(LOG_ERR, _("Metadata socket read error for %s (%s): %s"),
+			logger(LOG_ERR, _("Metadata socket read error for %s (%s): %s"),
 				   c->name, c->hostname, strerror(errno));
 
-		return -1;
+		return false;
 	}
 
 	oldlen = c->buflen;
@@ -139,7 +131,7 @@ int receive_meta(connection_t *c)
 		if(c->status.decryptin && !decrypted) {
 			EVP_DecryptUpdate(c->inctx, inbuf, &lenin, c->buffer + oldlen, lenin);
 			memcpy(c->buffer + oldlen, inbuf, lenin);
-			decrypted = 1;
+			decrypted = true;
 		}
 
 		/* Are we receiving a TCPpacket? */
@@ -173,8 +165,8 @@ int receive_meta(connection_t *c)
 
 		if(reqlen) {
 			c->reqlen = reqlen;
-			if(receive_request(c))
-				return -1;
+			if(!receive_request(c))
+				return false;
 
 			c->buflen -= reqlen;
 			lenin -= reqlen;
@@ -187,12 +179,12 @@ int receive_meta(connection_t *c)
 	}
 
 	if(c->buflen >= MAXBUFSIZE) {
-		syslog(LOG_ERR, _("Metadata read buffer overflow for %s (%s)"),
+		logger(LOG_ERR, _("Metadata read buffer overflow for %s (%s)"),
 			   c->name, c->hostname);
-		return -1;
+		return false;
 	}
 
 	c->last_ping_time = now;
 
-	return 0;
+	return true;
 }