X-Git-Url: https://tinc-vpn.org/git/browse?p=tinc;a=blobdiff_plain;f=src%2Fnet.c;h=71836a70a9bdb171b43680f694449f095f2f79bc;hp=b3474c371b8bf85cf37d37948a9b6eba1cc6e6bf;hb=a7ad161d2b115b6a2a69c5dc8ddd33008d3562d0;hpb=78532475238b23eb52ac88d905fbf966d97a79d2

diff --git a/src/net.c b/src/net.c
index b3474c37..71836a70 100644
--- a/src/net.c
+++ b/src/net.c
@@ -1,6 +1,7 @@
 /*
     net.c -- most of the network code
-    Copyright (C) 1998,99 Ivo Timmermans <zarq@iname.com>
+    Copyright (C) 1998,1999,2000 Ivo Timmermans <itimmermans@bigfoot.com>,
+                            2000 Guus Sliepen <guus@sliepen.warande.net>
 
     This program is free software; you can redistribute it and/or modify
     it under the terms of the GNU General Public License as published by
@@ -15,6 +16,8 @@
     You should have received a copy of the GNU General Public License
     along with this program; if not, write to the Free Software
     Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+
+    $Id: net.c,v 1.32 2000/05/29 23:40:05 guus Exp $
 */
 
 #include "config.h"
@@ -44,6 +47,8 @@
 #include "netutl.h"
 #include "protocol.h"
 
+#include "system.h"
+
 int tap_fd = -1;
 
 int total_tap_in = 0;
@@ -51,7 +56,7 @@ int total_tap_out = 0;
 int total_socket_in = 0;
 int total_socket_out = 0;
 
-time_t last_ping_time = 0;
+static int seconds_till_retry;
 
 /* The global list of existing connections */
 conn_list_t *conn_list = NULL;
@@ -98,20 +103,22 @@ cp
   rp.len = htons(rp.len);
 
   if(debug_lvl > 3)
-    syslog(LOG_ERR, "Sent %d bytes to %lx", ntohs(rp.len), cl->vpn_ip);
+    syslog(LOG_ERR, _("Sent %d bytes to %lx"), ntohs(rp.len), cl->vpn_ip);
 
   if((r = send(cl->socket, (char*)&rp, ntohs(rp.len), 0)) < 0)
     {
-      syslog(LOG_ERR, "Error sending data: %m");
+      syslog(LOG_ERR, _("Error sending data: %m"));
       return -1;
     }
 
   total_socket_out += r;
+
+  cl->want_ping = 1;
 cp
   return 0;
 }
 
-int xrecv(conn_list_t *cl, real_packet_t *packet)
+int xrecv(conn_list_t *cl, void *packet)
 {
   vpn_packet_t vp;
   int lenin;
@@ -120,9 +127,12 @@ cp
   add_mac_addresses(&vp);
 
   if((lenin = write(tap_fd, &vp, vp.len + sizeof(vp.len))) < 0)
-    syslog(LOG_ERR, "Can't write to tap device: %m");
+    syslog(LOG_ERR, _("Can't write to tap device: %m"));
   else
     total_tap_out += lenin;
+
+  cl->want_ping = 0;
+  cl->last_ping_time = time(NULL);
 cp
   return 0;
 }
@@ -136,7 +146,7 @@ void add_queue(packet_queue_t **q, void *packet, size_t s)
   queue_element_t *e;
 cp
   if(debug_lvl > 3)
-    syslog(LOG_DEBUG, "packet to queue: %d", s);
+    syslog(LOG_DEBUG, _("packet to queue: %d"), s);
 
   e = xmalloc(sizeof(*e));
   e->packet = xmalloc(s);
@@ -223,7 +233,7 @@ cp
     }
 
   if(debug_lvl > 3)
-    syslog(LOG_DEBUG, "queue flushed");
+    syslog(LOG_DEBUG, _("queue flushed"));
 cp
 }
 
@@ -238,7 +248,7 @@ cp
   if(cl->sq)
     {
       if(debug_lvl > 1)
-	syslog(LOG_DEBUG, "Flushing send queue for " IP_ADDR_S,
+	syslog(LOG_DEBUG, _("Flushing send queue for " IP_ADDR_S),
 	       IP_ADDR_V(cl->vpn_ip));
       flush_queue(cl, &(cl->sq), xsend);
     }
@@ -246,7 +256,7 @@ cp
   if(cl->rq)
     {
       if(debug_lvl > 1)
-	syslog(LOG_DEBUG, "Flushing receive queue for " IP_ADDR_S,
+	syslog(LOG_DEBUG, _("Flushing receive queue for " IP_ADDR_S),
 	       IP_ADDR_V(cl->vpn_ip));
       flush_queue(cl, &(cl->rq), xrecv);
     }
@@ -264,14 +274,14 @@ cp
     {
       if(debug_lvl > 2)
         {
-          syslog(LOG_NOTICE, "trying to look up " IP_ADDR_S " in connection list failed.",
+          syslog(LOG_NOTICE, _("trying to look up " IP_ADDR_S " in connection list failed."),
 	         IP_ADDR_V(to));
         }
       for(cl = conn_list; cl != NULL && !cl->status.outgoing; cl = cl->next);
       if(!cl)
         { /* No open outgoing connection has been found. */
 	  if(debug_lvl > 2)
-	    syslog(LOG_NOTICE, "There is no remote host I can send this packet to.");
+	    syslog(LOG_NOTICE, _("There is no remote host I can send this packet to."));
           return -1;
         }
     }
@@ -295,7 +305,7 @@ cp
     {
       add_queue(&(cl->sq), packet, packet->len + 2);
       if(debug_lvl > 1)
-	syslog(LOG_INFO, IP_ADDR_S " is not ready, queueing packet.", IP_ADDR_V(cl->vpn_ip));
+	syslog(LOG_INFO, _(IP_ADDR_S " is not ready, queueing packet."), IP_ADDR_V(cl->vpn_ip));
       return 0; /* We don't want to mess up, do we? */
     }
 
@@ -304,21 +314,6 @@ cp
   return xsend(cl, packet);
 }
 
-int send_broadcast(conn_list_t *cl, vpn_packet_t *packet)
-{
-  conn_list_t *p;
-cp
-  for(p = cl; p != NULL; p = p->next)
-    if(send_packet(p->real_ip, packet) < 0)
-      {
-	syslog(LOG_ERR, "Could not send a broadcast packet to %08lx (%08lx): %m",
-	       p->vpn_ip, p->real_ip);
-	break; /* FIXME: should retry later, and send a ping over the metaconnection. */
-      }
-cp
-  return 0;
-}
-
 /*
   open the local ethertap device
 */
@@ -335,7 +330,7 @@ cp
 
   if((nfd = open(tapfname, O_RDWR | O_NONBLOCK)) < 0)
     {
-      syslog(LOG_ERR, "Could not open %s: %m", tapfname);
+      syslog(LOG_ERR, _("Could not open %s: %m"), tapfname);
       return -1;
     }
 
@@ -356,20 +351,20 @@ int setup_listen_meta_socket(int port)
 cp
   if((nfd = socket(AF_INET, SOCK_STREAM, IPPROTO_TCP)) < 0)
     {
-      syslog(LOG_ERR, "Creating metasocket failed: %m");
+      syslog(LOG_ERR, _("Creating metasocket failed: %m"));
       return -1;
     }
 
   if(setsockopt(nfd, SOL_SOCKET, SO_REUSEADDR, &one, sizeof(one)))
     {
-      syslog(LOG_ERR, "setsockopt: %m");
+      syslog(LOG_ERR, _("setsockopt: %m"));
       return -1;
     }
 
   flags = fcntl(nfd, F_GETFL);
   if(fcntl(nfd, F_SETFL, flags | O_NONBLOCK) < 0)
     {
-      syslog(LOG_ERR, "fcntl: %m");
+      syslog(LOG_ERR, _("fcntl: %m"));
       return -1;
     }
 
@@ -380,13 +375,13 @@ cp
 
   if(bind(nfd, (struct sockaddr *)&a, sizeof(struct sockaddr)))
     {
-      syslog(LOG_ERR, "Can't bind to port %hd/tcp: %m", port);
+      syslog(LOG_ERR, _("Can't bind to port %hd/tcp: %m"), port);
       return -1;
     }
 
   if(listen(nfd, 3))
     {
-      syslog(LOG_ERR, "listen: %m");
+      syslog(LOG_ERR, _("listen: %m"));
       return -1;
     }
 cp
@@ -405,20 +400,20 @@ int setup_vpn_in_socket(int port)
 cp
   if((nfd = socket(AF_INET, SOCK_DGRAM, IPPROTO_UDP)) < 0)
     {
-      syslog(LOG_ERR, "Creating socket failed: %m");
+      syslog(LOG_ERR, _("Creating socket failed: %m"));
       return -1;
     }
 
   if(setsockopt(nfd, SOL_SOCKET, SO_REUSEADDR, &one, sizeof(one)))
     {
-      syslog(LOG_ERR, "setsockopt: %m");
+      syslog(LOG_ERR, _("setsockopt: %m"));
       return -1;
     }
 
   flags = fcntl(nfd, F_GETFL);
   if(fcntl(nfd, F_SETFL, flags | O_NONBLOCK) < 0)
     {
-      syslog(LOG_ERR, "fcntl: %m");
+      syslog(LOG_ERR, _("fcntl: %m"));
       return -1;
     }
 
@@ -429,7 +424,7 @@ cp
 
   if(bind(nfd, (struct sockaddr *)&a, sizeof(struct sockaddr)))
     {
-      syslog(LOG_ERR, "Can't bind to port %hd/udp: %m", port);
+      syslog(LOG_ERR, _("Can't bind to port %hd/udp: %m"), port);
       return -1;
     }
 cp
@@ -453,7 +448,7 @@ cp
   cl->meta_socket = socket(AF_INET, SOCK_STREAM, IPPROTO_TCP);
   if(cl->meta_socket == -1)
     {
-      syslog(LOG_ERR, "Creating socket failed: %m");
+      syslog(LOG_ERR, _("Creating socket failed: %m"));
       return -1;
     }
 
@@ -463,20 +458,20 @@ cp
 
   if(connect(cl->meta_socket, (struct sockaddr *)&a, sizeof(a)) == -1)
     {
-      syslog(LOG_ERR, IP_ADDR_S ":%d: %m", IP_ADDR_V(cl->real_ip), cl->port);
+      syslog(LOG_ERR, _(IP_ADDR_S ":%d: %m"), IP_ADDR_V(cl->real_ip), cl->port);
       return -1;
     }
 
   flags = fcntl(cl->meta_socket, F_GETFL);
   if(fcntl(cl->meta_socket, F_SETFL, flags | O_NONBLOCK) < 0)
     {
-      syslog(LOG_ERR, "fcntl: %m");
+      syslog(LOG_ERR, _("fcntl: %m"));
       return -1;
     }
 
   cl->hostname = hostlookup(htonl(cl->real_ip));
 
-  syslog(LOG_INFO, "Connected to %s:%hd" , cl->hostname, cl->port);
+  syslog(LOG_INFO, _("Connected to %s:%hd"), cl->hostname, cl->port);
 cp
   return 0;
 }
@@ -497,7 +492,7 @@ cp
 
   if(setup_outgoing_meta_socket(ncn) < 0)
     {
-      syslog(LOG_ERR, "Could not set up a meta connection.");
+      syslog(LOG_ERR, _("Could not set up a meta connection."));
       free_conn_element(ncn);
       return -1;
     }
@@ -521,7 +516,7 @@ cp
 
   if(!(cfg = get_config_val(myvpnip)))
     {
-      syslog(LOG_ERR, "No value for my VPN IP given");
+      syslog(LOG_ERR, _("No value for my VPN IP given"));
       return -1;
     }
 
@@ -535,24 +530,48 @@ cp
 
   if((myself->meta_socket = setup_listen_meta_socket(myself->port)) < 0)
     {
-      syslog(LOG_ERR, "Unable to set up a listening socket");
+      syslog(LOG_ERR, _("Unable to set up a listening socket"));
       return -1;
     }
 
   if((myself->socket = setup_vpn_in_socket(myself->port)) < 0)
     {
-      syslog(LOG_ERR, "Unable to set up an incoming vpn data socket");
+      syslog(LOG_ERR, _("Unable to set up an incoming vpn data socket"));
       close(myself->meta_socket);
       return -1;
     }
 
   myself->status.active = 1;
 
-  syslog(LOG_NOTICE, "Ready: listening on port %d.", myself->port);
+  syslog(LOG_NOTICE, _("Ready: listening on port %d."), myself->port);
 cp
   return 0;
 }
 
+RETSIGTYPE
+sigalrm_handler(int a)
+{
+  config_t const *cfg;
+cp
+  cfg = get_config_val(upstreamip);
+
+  if(!setup_outgoing_connection(cfg->data.ip->ip))
+    {
+      signal(SIGALRM, SIG_IGN);
+    }
+  else
+    {
+      signal(SIGALRM, sigalrm_handler);
+      seconds_till_retry += 5;
+      if(seconds_till_retry>300)    /* Don't wait more than 5 minutes. */
+        seconds_till_retry = 300;
+      alarm(seconds_till_retry);
+      syslog(LOG_ERR, _("Still failed to connect to other. Will retry in %d seconds."),
+	     seconds_till_retry);
+    }
+cp
+}
+
 /*
   setup all initial network connections
 */
@@ -561,7 +580,7 @@ int setup_network_connections(void)
   config_t const *cfg;
 cp
   if((cfg = get_config_val(pingtimeout)) == NULL)
-    timeout = 10;
+    timeout = 5;
   else
     timeout = cfg->data.val;
 
@@ -576,33 +595,14 @@ cp
     return 0;
 
   if(setup_outgoing_connection(cfg->data.ip->ip))
-    return -1;
-cp
-  return 0;
-}
-
-RETSIGTYPE
-sigalrm_handler(int a)
-{
-  config_t const *cfg;
-  static int seconds_till_retry;
-cp
-  cfg = get_config_val(upstreamip);
-
-  if(!setup_outgoing_connection(cfg->data.ip->ip))
-    {
-      signal(SIGALRM, SIG_IGN);
-      seconds_till_retry = 5;
-    }
-  else
     {
       signal(SIGALRM, sigalrm_handler);
-      seconds_till_retry += 5;
+      seconds_till_retry = 300;
       alarm(seconds_till_retry);
-      syslog(LOG_ERR, "Still failed to connect to other. Will retry in %d seconds.",
-	     seconds_till_retry);
+      syslog(LOG_NOTICE, _("Try to re-establish outgoing connection in 5 minutes."));
     }
 cp
+  return 0;
 }
 
 /*
@@ -637,7 +637,7 @@ cp
   close(tap_fd);
   destroy_conn_list();
 
-  syslog(LOG_NOTICE, "Terminating.");
+  syslog(LOG_NOTICE, _("Terminating."));
 cp
   return;
 }
@@ -651,12 +651,12 @@ int setup_vpn_connection(conn_list_t *cl)
   struct sockaddr_in a;
 cp
   if(debug_lvl > 1)
-    syslog(LOG_DEBUG, "Opening UDP socket to " IP_ADDR_S, IP_ADDR_V(cl->real_ip));
+    syslog(LOG_DEBUG, _("Opening UDP socket to " IP_ADDR_S), IP_ADDR_V(cl->real_ip));
 
   nfd = socket(AF_INET, SOCK_DGRAM, IPPROTO_UDP);
   if(nfd == -1)
     {
-      syslog(LOG_ERR, "Creating data socket failed: %m");
+      syslog(LOG_ERR, _("Creating data socket failed: %m"));
       return -1;
     }
 
@@ -666,15 +666,15 @@ cp
 
   if(connect(nfd, (struct sockaddr *)&a, sizeof(a)) == -1)
     {
-      syslog(LOG_ERR, "Create connection to %08lx:%d failed: %m", ntohs(cl->real_ip),
-	     cl->port);
+      syslog(LOG_ERR, _("Connecting to " IP_ADDR_S ":%d failed: %m"),
+	     IP_ADDR_V(cl->real_ip), cl->port);
       return -1;
     }
 
   flags = fcntl(nfd, F_GETFL);
   if(fcntl(nfd, F_SETFL, flags | O_NONBLOCK) < 0)
     {
-      syslog(LOG_ERR, "This is a bug: %s:%d: %d:%m", __FILE__, __LINE__, nfd);
+      syslog(LOG_ERR, _("This is a bug: %s:%d: %d:%m"), __FILE__, __LINE__, nfd);
       return -1;
     }
 
@@ -698,7 +698,7 @@ cp
 
   if(getpeername(sfd, &ci, &len) < 0)
     {
-      syslog(LOG_ERR, "Error: getpeername: %m");
+      syslog(LOG_ERR, _("Error: getpeername: %m"));
       return NULL;
     }
 
@@ -707,8 +707,10 @@ cp
   p->meta_socket = sfd;
   p->status.meta = 1;
   p->buflen = 0;
+  p->last_ping_time = time(NULL);
+  p->want_ping = 0;
   
-  syslog(LOG_NOTICE, "Connection from %s:%d", p->hostname, htons(ci.sin_port));
+  syslog(LOG_NOTICE, _("Connection from %s:%d"), p->hostname, htons(ci.sin_port));
 
   if(send_basic_info(p) < 0)
     {
@@ -756,12 +758,12 @@ int handle_incoming_vpn_data(conn_list_t *cl)
 cp
   if(getsockopt(cl->socket, SOL_SOCKET, SO_ERROR, &x, &l) < 0)
     {
-      syslog(LOG_ERR, "This is a bug: %s:%d: %d:%m", __FILE__, __LINE__, cl->socket);
+      syslog(LOG_ERR, _("This is a bug: %s:%d: %d:%m"), __FILE__, __LINE__, cl->socket);
       return -1;
     }
   if(x)
     {
-      syslog(LOG_ERR, "Incoming data socket error: %s", sys_errlist[x]);
+      syslog(LOG_ERR, _("Incoming data socket error: %s"), sys_errlist[x]);
       return -1;
     }
 
@@ -769,7 +771,7 @@ cp
   lenin = recvfrom(cl->socket, &rp, MTU, 0, NULL, NULL);
   if(lenin <= 0)
     {
-      syslog(LOG_ERR, "Receiving data failed: %m");
+      syslog(LOG_ERR, _("Receiving data failed: %m"));
       return -1;
     }
   total_socket_in += lenin;
@@ -782,11 +784,11 @@ cp
     {
       f = lookup_conn(rp.from);
       if(debug_lvl > 3)
-	syslog(LOG_DEBUG, "packet from " IP_ADDR_S " (len %d)",
+	syslog(LOG_DEBUG, _("packet from " IP_ADDR_S " (len %d)"),
 	       IP_ADDR_V(rp.from), rp.len);
       if(!f)
 	{
-	  syslog(LOG_ERR, "Got packet from unknown source " IP_ADDR_S,
+	  syslog(LOG_ERR, _("Got packet from unknown source " IP_ADDR_S),
 		 IP_ADDR_V(rp.from));
 	  return -1;
 	}
@@ -818,7 +820,7 @@ cp
     return;
 
   if(debug_lvl > 0)
-    syslog(LOG_NOTICE, "Closing connection with %s.", cl->hostname);
+    syslog(LOG_NOTICE, _("Closing connection with %s."), cl->hostname);
 
   if(cl->status.timeout)
     send_timeout(cl);
@@ -831,62 +833,54 @@ cp
 
   if(cl->status.outgoing)
     {
-      alarm(5);
       signal(SIGALRM, sigalrm_handler);
-      syslog(LOG_NOTICE, "Try to re-establish outgoing connection in 5 seconds.");
+      seconds_till_retry = 5;
+      alarm(seconds_till_retry);
+      syslog(LOG_NOTICE, _("Try to re-establish outgoing connection in 5 seconds."));
     }
   
+  cl->status.active = 0;
   cl->status.remove = 1;
 cp
 }
 
 /*
-  send out a ping request to all active
-  connections
-*/
-int send_broadcast_ping(void)
-{
-  conn_list_t *p;
-cp
-  for(p = conn_list; p != NULL; p = p->next)
-    {
-      if(p->status.remove)
-	continue;
-      if(p->status.active && p->status.meta)
-	{
-	  if(send_ping(p))
-	    terminate_connection(p);
-	  else
-	    {
-	      p->status.pinged = 1;
-	      p->status.got_pong = 0;
-	    }
-	}
-    }
-
-  last_ping_time = time(NULL);
-cp
-  return 0;
-}
-
-/*
-  end all connections that did not respond
-  to the ping probe in time
+  Check if the other end is active.
+  If we have sent packets, but didn't receive any,
+  then possibly the other end is dead. We send a
+  PING request over the meta connection. If the other
+  end does not reply in time, we consider them dead
+  and close the connection.
 */
 int check_dead_connections(void)
 {
   conn_list_t *p;
+  time_t now;
 cp
+  now = time(NULL);
   for(p = conn_list; p != NULL; p = p->next)
     {
       if(p->status.remove)
 	continue;
-      if(p->status.active && p->status.meta && p->status.pinged && !p->status.got_pong)
+      if(p->status.active && p->status.meta)
 	{
-	  syslog(LOG_INFO, "%s (" IP_ADDR_S ") didn't respond to ping",
-		 p->hostname, IP_ADDR_V(p->vpn_ip));
-	  p->status.timeout = 1;
-	  terminate_connection(p);
+          if(p->last_ping_time + timeout < now)
+            {
+              if(p->status.pinged && !p->status.got_pong)
+                {
+	          syslog(LOG_INFO, _("%s (" IP_ADDR_S ") didn't respond to ping"),
+		         p->hostname, IP_ADDR_V(p->vpn_ip));
+	          p->status.timeout = 1;
+	          terminate_connection(p);
+                }
+              else if(p->want_ping)
+                {
+                  send_ping(p);
+                  p->last_ping_time = now;
+                  p->status.pinged = 1;
+                  p->status.got_pong = 0;
+                }
+            }
 	}
     }
 cp
@@ -905,7 +899,7 @@ int handle_new_meta_connection(conn_list_t *cl)
 cp
   if((nfd = accept(cl->meta_socket, &client, &len)) < 0)
     {
-      syslog(LOG_ERR, "Accepting a new connection failed: %m");
+      syslog(LOG_ERR, _("Accepting a new connection failed: %m"));
       return -1;
     }
 
@@ -913,7 +907,7 @@ cp
     {
       shutdown(nfd, 2);
       close(nfd);
-      syslog(LOG_NOTICE, "Closed attempted connection.");
+      syslog(LOG_NOTICE, _("Closed attempted connection."));
       return 0;
     }
 
@@ -935,26 +929,26 @@ int handle_incoming_meta_data(conn_list_t *cl)
 cp
   if(getsockopt(cl->meta_socket, SOL_SOCKET, SO_ERROR, &x, &l) < 0)
     {
-      syslog(LOG_ERR, "This is a bug: %s:%d: %d:%m", __FILE__, __LINE__, cl->meta_socket);
+      syslog(LOG_ERR, _("This is a bug: %s:%d: %d:%m"), __FILE__, __LINE__, cl->meta_socket);
       return -1;
     }
   if(x)
     {
-      syslog(LOG_ERR, "Metadata socket error: %s", sys_errlist[x]);
+      syslog(LOG_ERR, _("Metadata socket error: %s"), sys_errlist[x]);
       return -1;
     }
 
   if(cl->buflen >= MAXBUFSIZE)
     {
-      syslog(LOG_ERR, "Metadata read buffer full! Discarding contents.");
-      cl->buflen = 0;
+      syslog(LOG_ERR, _("Metadata read buffer overflow."));
+      return -1;
     }
 
   lenin = read(cl->meta_socket, cl->buffer, MAXBUFSIZE-cl->buflen);
 
   if(lenin<=0)
     {
-      syslog(LOG_ERR, "Metadata socket read error: %m");
+      syslog(LOG_ERR, _("Metadata socket read error: %m"));
       return -1;
     }
 
@@ -979,20 +973,25 @@ cp
         {
           if(sscanf(cl->buffer, "%d", &request) == 1)
             {
-              if(request_handlers[request] == NULL)
+              if((request < 0) || (request > 255) || (request_handlers[request] == NULL))
                 {
-                  syslog(LOG_ERR, "Unknown request: %s", cl->buffer);
-                  return 0;
+                  syslog(LOG_ERR, _("Unknown request: %s"), cl->buffer);
+                  return -1;
                 }
 
               if(debug_lvl > 3)
-                syslog(LOG_DEBUG, "Got request: %s", cl->buffer);                             
+                syslog(LOG_DEBUG, _("Got request: %s"), cl->buffer);                             
 
-              request_handlers[request](cl);
+              if(request_handlers[request](cl))  /* Something went wrong. Probably scriptkiddies. Terminate. */
+                {
+                  syslog(LOG_ERR, _("Error while processing request from " IP_ADDR_S), IP_ADDR_V(cl->real_ip));
+                  return -1;
+                }
             }
           else
             {
-              syslog(LOG_ERR, "Bogus data received: %s", cl->buffer);
+              syslog(LOG_ERR, _("Bogus data received."));
+              return -1;
             }
 
           cl->buflen -= cl->reqlen;
@@ -1004,6 +1003,9 @@ cp
           break;
         }
     }
+
+  cl->last_ping_time = time(NULL);
+  cl->want_ping = 0;
 cp  
   return 0;
 }
@@ -1032,7 +1034,7 @@ cp
 	      I've once got here when it said `No route to host'.
 	    */
 	    getsockopt(p->socket, SOL_SOCKET, SO_ERROR, &x, &l);
-	    syslog(LOG_ERR, "Outgoing data socket error: %s", sys_errlist[x]);
+	    syslog(LOG_ERR, _("Outgoing data socket error: %s"), sys_errlist[x]);
 	    terminate_connection(p);
 	    return;
 	  }  
@@ -1067,7 +1069,7 @@ cp
   memset(&vp, 0, sizeof(vp));
   if((lenin = read(tap_fd, &vp, MTU)) <= 0)
     {
-      syslog(LOG_ERR, "Error while reading from tapdevice: %m");
+      syslog(LOG_ERR, _("Error while reading from tapdevice: %m"));
       return;
     }
 
@@ -1077,7 +1079,7 @@ cp
   if(ether_type != 0x0800)
     {
       if(debug_lvl > 0)
-	syslog(LOG_INFO, "Non-IP ethernet frame %04x from " MAC_ADDR_S,
+	syslog(LOG_INFO, _("Non-IP ethernet frame %04x from " MAC_ADDR_S),
 	       ether_type, MAC_ADDR_V(vp.data[6]));
       return;
     }
@@ -1085,7 +1087,7 @@ cp
   if(lenin < 32)
     {
       if(debug_lvl > 0)
-	syslog(LOG_INFO, "Dropping short packet");
+	syslog(LOG_INFO, _("Dropping short packet"));
       return;
     }
 
@@ -1093,10 +1095,10 @@ cp
   to = ntohl(*((unsigned long*)(&vp.data[30])));
 
   if(debug_lvl > 3)
-    syslog(LOG_DEBUG, "An IP packet (%04x) for " IP_ADDR_S " from " IP_ADDR_S,
+    syslog(LOG_DEBUG, _("An IP packet (%04x) for " IP_ADDR_S " from " IP_ADDR_S),
 	   ether_type, IP_ADDR_V(to), IP_ADDR_V(from));
   if(debug_lvl > 4)
-    syslog(LOG_DEBUG, MAC_ADDR_S " to " MAC_ADDR_S,
+    syslog(LOG_DEBUG, _(MAC_ADDR_S " to " MAC_ADDR_S),
 	   MAC_ADDR_V(vp.data[0]), MAC_ADDR_V(vp.data[6]));
   
   vp.len = (length_t)lenin - 2;
@@ -1115,8 +1117,9 @@ void main_loop(void)
   fd_set fset;
   struct timeval tv;
   int r;
+  time_t last_ping_check;
 cp
-  last_ping_time = time(NULL);
+  last_ping_check = time(NULL);
 
   for(;;)
     {
@@ -1130,15 +1133,15 @@ cp
         {
 	  if(errno == EINTR) /* because of alarm */
 	    continue;
-          syslog(LOG_ERR, "Error while waiting for input: %m");
+          syslog(LOG_ERR, _("Error while waiting for input: %m"));
           return;
         }
 
-      if(r == 0 || last_ping_time + timeout < time(NULL))
-	/* Timeout... hm... something might be wrong. */
+      if(last_ping_check + timeout < time(NULL))
+	/* Let's check if everybody is still alive */
 	{
 	  check_dead_connections();
-	  send_broadcast_ping();
+          last_ping_check = time(NULL);
 	  continue;
 	}