X-Git-Url: https://tinc-vpn.org/git/browse?p=tinc;a=blobdiff_plain;f=src%2Fprotocol.c;h=0385c9c0c8bb1aa6f61e6c00b1ae94a92abad633;hp=18fe4409455459313ca9df3bbceb10728b3cf54e;hb=a7ad161d2b115b6a2a69c5dc8ddd33008d3562d0;hpb=75d351eaf1264cfb7aa47166469e8ec722712a89

diff --git a/src/protocol.c b/src/protocol.c
index 18fe4409..0385c9c0 100644
--- a/src/protocol.c
+++ b/src/protocol.c
@@ -1,6 +1,7 @@
 /*
     protocol.c -- handle the meta-protocol
-    Copyright (C) 1999 Ivo Timmermans <zarq@iname.com>
+    Copyright (C) 1999,2000 Ivo Timmermans <itimmermans@bigfoot.com>,
+                       2000 Guus Sliepen <guus@sliepen.warande.net>
 
     This program is free software; you can redistribute it and/or modify
     it under the terms of the GNU General Public License as published by
@@ -15,15 +16,20 @@
     You should have received a copy of the GNU General Public License
     along with this program; if not, write to the Free Software
     Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+
+    $Id: protocol.c,v 1.27 2000/05/29 23:40:05 guus Exp $
 */
 
 #include "config.h"
 
+#include <sys/types.h>
+
 #include <stdlib.h>
 #include <string.h>
 #include <syslog.h>
 #include <sys/socket.h>
 #include <unistd.h>
+#include <stdio.h>
 
 #include <utils.h>
 #include <xalloc.h>
@@ -34,38 +40,45 @@
 #include "netutl.h"
 #include "protocol.h"
 
+#include "system.h"
+
+char buffer[MAXBUFSIZE+1];
+int buflen;
+
+/* Outgoing request routines */
+
 int send_ack(conn_list_t *cl)
 {
-  unsigned char tmp = ACK;
 cp
   if(debug_lvl > 2)
-    syslog(LOG_DEBUG, "Send ACK to %s", cl->hostname);
+    syslog(LOG_DEBUG, _("Send ACK to %s"), cl->hostname);
+
+  buflen = snprintf(buffer, MAXBUFSIZE, "%d\n", ACK);
 
-  syslog(LOG_NOTICE, "Connection with %s activated.", cl->hostname);
-  if((write(cl->meta_socket, &tmp, sizeof(tmp))) < 0)
+  if((write(cl->meta_socket, buffer, buflen)) < 0)
     {
-      syslog(LOG_ERR, "send failed: %d:%d: %m", __FILE__, __LINE__);
+      syslog(LOG_ERR, _("send failed: %d:%d: %m"), __FILE__, __LINE__);
       return -1;
     }
+
+  syslog(LOG_NOTICE, _("Connection with %s activated."), cl->hostname);
 cp
   return 0;
 }
 
 int send_termreq(conn_list_t *cl)
 {
-  termreq_t tmp;
 cp
-  memset(&tmp, 0, sizeof(tmp));
-  tmp.type = TERMREQ;
-  tmp.vpn_ip = myself->vpn_ip;
-
   if(debug_lvl > 2)
-    syslog(LOG_DEBUG, "Send TERMREQ(" IP_ADDR_S ") to " IP_ADDR_S, IP_ADDR_V(tmp.vpn_ip),
+    syslog(LOG_DEBUG, _("Send TERMREQ to " IP_ADDR_S),
 	   IP_ADDR_V(cl->vpn_ip));
 
-  if((write(cl->meta_socket, &tmp, sizeof(tmp))) < 0)
+  buflen = snprintf(buffer, MAXBUFSIZE, "%d %lx\n", TERMREQ, myself->vpn_ip);
+
+  if(write(cl->meta_socket, buffer, buflen) < 0)
     {
-      syslog(LOG_ERR, "send failed: %s:%d: %m", __FILE__, __LINE__);
+      if(debug_lvl > 1)
+	syslog(LOG_ERR, _("send failed: %s:%d: %m"), __FILE__, __LINE__);
       return -1;
     }
 cp
@@ -74,19 +87,16 @@ cp
 
 int send_timeout(conn_list_t *cl)
 {
-  termreq_t tmp;
 cp
-  memset(&tmp, 0, sizeof(tmp));
-  tmp.type = PINGTIMEOUT;
-  tmp.vpn_ip = myself->vpn_ip;
-
   if(debug_lvl > 2)
-    syslog(LOG_DEBUG, "Send TIMEOUT(" IP_ADDR_S ") to " IP_ADDR_S, IP_ADDR_V(tmp.vpn_ip),
+    syslog(LOG_DEBUG, _("Send TIMEOUT to " IP_ADDR_S),
 	   IP_ADDR_V(cl->vpn_ip));
 
-  if((write(cl->meta_socket, &tmp, sizeof(tmp))) < 0)
+  buflen = snprintf(buffer, MAXBUFSIZE, "%d %lx\n", PINGTIMEOUT, myself->vpn_ip);
+
+  if((write(cl->meta_socket, buffer, buflen)) < 0)
     {
-      syslog(LOG_ERR, "send failed: %s:%d: %m", __FILE__, __LINE__);
+      syslog(LOG_ERR, _("send failed: %s:%d: %m"), __FILE__, __LINE__);
       return -1;
     }
 cp
@@ -95,19 +105,16 @@ cp
 
 int send_del_host(conn_list_t *cl, conn_list_t *new_host)
 {
-  del_host_t tmp;
 cp
-  memset(&tmp, 0, sizeof(tmp));
-  tmp.type = DEL_HOST;
-  tmp.vpn_ip = new_host->vpn_ip;
-
   if(debug_lvl > 2)
-    syslog(LOG_DEBUG, "Sending delete host %lx to " IP_ADDR_S,
-	   tmp.vpn_ip, IP_ADDR_V(cl->vpn_ip));
+    syslog(LOG_DEBUG, _("Sending delete host " IP_ADDR_S " to " IP_ADDR_S),
+	   IP_ADDR_V(new_host->vpn_ip), IP_ADDR_V(cl->vpn_ip));
 
-  if((write(cl->meta_socket, &tmp, sizeof(tmp))) < 0)
+  buflen = snprintf(buffer, MAXBUFSIZE, "%d %lx\n", DEL_HOST, new_host->vpn_ip);
+
+  if((write(cl->meta_socket, buffer, buflen)) < 0)
     {
-      syslog(LOG_ERR, "send failed: %s:%d: %m", __FILE__, __LINE__);
+      syslog(LOG_ERR, _("send failed: %s:%d: %m"), __FILE__, __LINE__);
       return -1;
     }
 cp
@@ -116,14 +123,15 @@ cp
 
 int send_ping(conn_list_t *cl)
 {
-  unsigned char tmp = PING;
 cp
   if(debug_lvl > 3)
-    syslog(LOG_DEBUG, "pinging " IP_ADDR_S, IP_ADDR_V(cl->vpn_ip));
+    syslog(LOG_DEBUG, _("pinging " IP_ADDR_S), IP_ADDR_V(cl->vpn_ip));
+
+  buflen = snprintf(buffer, MAXBUFSIZE, "%d\n", PING);
 
-  if((write(cl->meta_socket, &tmp, sizeof(tmp))) < 0)
+  if((write(cl->meta_socket, buffer, buflen)) < 0)
     {
-      syslog(LOG_ERR, "send failed: %s:%d: %m", __FILE__, __LINE__);
+      syslog(LOG_ERR, _("send failed: %s:%d: %m"), __FILE__, __LINE__);
       return -1;
     }
 cp
@@ -132,11 +140,12 @@ cp
 
 int send_pong(conn_list_t *cl)
 {
-  unsigned char tmp = PONG;
 cp
-  if((write(cl->meta_socket, &tmp, sizeof(tmp))) < 0)
+  buflen = snprintf(buffer, MAXBUFSIZE, "%d\n", PONG);
+
+  if((write(cl->meta_socket, buffer, buflen)) < 0)
     {
-      syslog(LOG_ERR, "send failed: %s:%d: %m", __FILE__, __LINE__);
+      syslog(LOG_ERR, _("send failed: %s:%d: %m"), __FILE__, __LINE__);
       return -1;
     }
 cp
@@ -145,23 +154,16 @@ cp
 
 int send_add_host(conn_list_t *cl, conn_list_t *new_host)
 {
-  add_host_t tmp;
 cp
-  memset(&tmp, 0, sizeof(tmp));
-  tmp.type = ADD_HOST;
-  tmp.real_ip = new_host->real_ip;
-  tmp.vpn_ip = new_host->vpn_ip;
-  tmp.vpn_mask = new_host->vpn_mask;
-  tmp.portnr = new_host->port;
-
   if(debug_lvl > 2)
-    syslog(LOG_DEBUG, "Sending add host (%lx/%lx %lx:%hd) to " IP_ADDR_S,
-	   tmp.vpn_ip, tmp.vpn_mask, tmp.real_ip, tmp.portnr,
+    syslog(LOG_DEBUG, _("Sending add host to " IP_ADDR_S),
 	   IP_ADDR_V(cl->vpn_ip));
 
-  if((write(cl->meta_socket, &tmp, sizeof(tmp))) < 0)
+  buflen = snprintf(buffer, MAXBUFSIZE, "%d %lx %lx/%lx:%x\n", ADD_HOST, new_host->real_ip, new_host->vpn_ip, new_host->vpn_mask, new_host->port);
+
+  if((write(cl->meta_socket, buffer, buflen)) < 0)
     {
-      syslog(LOG_ERR, "send failed: %s:%d: %m", __FILE__, __LINE__);
+      syslog(LOG_ERR, _("send failed: %s:%d: %m"), __FILE__, __LINE__);
       return -1;
     }
 cp
@@ -170,55 +172,44 @@ cp
 
 int send_key_changed(conn_list_t *cl, conn_list_t *src)
 {
-  key_changed_t tmp;
 cp
-  memset(&tmp, 0, sizeof(tmp));
-  tmp.type = KEY_CHANGED;
-  tmp.from = src->vpn_ip;
-
   if(debug_lvl > 2)
-    syslog(LOG_DEBUG, "Sending KEY_CHANGED (%lx) to " IP_ADDR_S,
-	   tmp.from, IP_ADDR_V(cl->vpn_ip));
+    syslog(LOG_DEBUG, _("Sending KEY_CHANGED to " IP_ADDR_S),
+	   IP_ADDR_V(cl->vpn_ip));
+
+  buflen = snprintf(buffer, MAXBUFSIZE, "%d %lx\n", KEY_CHANGED, src->vpn_ip);
 
-  if((write(cl->meta_socket, &tmp, sizeof(tmp))) < 0)
+  if((write(cl->meta_socket, buffer, buflen)) < 0)
     {
-      syslog(LOG_ERR, "send failed: %s:%d: %m", __FILE__, __LINE__);
+      syslog(LOG_ERR, _("send failed: %s:%d: %m"), __FILE__, __LINE__);
       return -1;
     }
 cp
   return 0;
 }
 
-void send_key_changed2(void)
+void send_key_changed_all(void)
 {
   conn_list_t *p;
 cp
   for(p = conn_list; p != NULL; p = p->next)
-    if(p->status.meta && p->protocol_version > PROT_3)
+    if(p->status.meta && p->status.active)
       send_key_changed(p, myself);
 cp
 }
 
 int send_basic_info(conn_list_t *cl)
 {
-  basic_info_t tmp;
 cp
-  memset(&tmp, 0, sizeof(tmp));
-  tmp.type = BASIC_INFO;
-  tmp.protocol = PROT_CURRENT;
-
-  tmp.portnr = myself->port;
-  tmp.vpn_ip = myself->vpn_ip;
-  tmp.vpn_mask = myself->vpn_mask;
-
   if(debug_lvl > 2)
-    syslog(LOG_DEBUG, "Send BASIC_INFO(%d,%hd," IP_ADDR_S "," IP_ADDR_S ") to " IP_ADDR_S,
-	   tmp.protocol, tmp.portnr, IP_ADDR_V(tmp.vpn_ip), IP_ADDR_V(tmp.vpn_mask),
+    syslog(LOG_DEBUG, _("Send BASIC_INFO to " IP_ADDR_S),
 	   IP_ADDR_V(cl->real_ip));
 
-  if((write(cl->meta_socket, &tmp, sizeof(tmp))) < 0)
+  buflen = snprintf(buffer, MAXBUFSIZE, "%d %d %lx/%lx:%x\n", BASIC_INFO, PROT_CURRENT, myself->vpn_ip, myself->vpn_mask, myself->port);
+
+  if((write(cl->meta_socket, buffer, buflen)) < 0)
     {
-      syslog(LOG_ERR, "send failed: %s:%d: %m", __FILE__, __LINE__);
+      syslog(LOG_ERR, _("send failed: %s:%d: %m"), __FILE__, __LINE__);
       return -1;
     }
 cp
@@ -229,17 +220,17 @@ int send_passphrase(conn_list_t *cl)
 {
   passphrase_t tmp;
 cp
-  memset(&tmp, 0, sizeof(tmp));
-  tmp.type = PASSPHRASE;
   encrypt_passphrase(&tmp);
 
   if(debug_lvl > 2)
-    syslog(LOG_DEBUG, "Send PASSPHRASE(%hd,...) to " IP_ADDR_S, tmp.len,
-	   IP_ADDR_V(cl->vpn_ip));
+    syslog(LOG_DEBUG, _("Send PASSPHRASE %s to " IP_ADDR_S),
+	   tmp.phrase, IP_ADDR_V(cl->vpn_ip));
 
-  if((write(cl->meta_socket, &tmp, tmp.len+3)) < 0)
+  buflen = snprintf(buffer, MAXBUFSIZE, "%d %s\n", PASSPHRASE, tmp.phrase);
+
+  if((write(cl->meta_socket, buffer, buflen)) < 0)
     {
-      syslog(LOG_ERR, "send failed: %s:%d: %m", __FILE__, __LINE__);
+      syslog(LOG_ERR, _("send failed: %s:%d: %m"), __FILE__, __LINE__);
       return -1;
     }
 cp
@@ -248,21 +239,16 @@ cp
 
 int send_public_key(conn_list_t *cl)
 {
-  public_key_t *tmp;
 cp
-  tmp = (public_key_t*)xmalloc(strlen(my_public_key_base36)+sizeof(*tmp));
-  memset(tmp, 0, sizeof(*tmp));
-  tmp->type = PUBLIC_KEY;
-  tmp->len = strlen(my_public_key_base36);
-  strcpy(&tmp->key, my_public_key_base36);
-
   if(debug_lvl > 2)
-    syslog(LOG_DEBUG, "Send PUBLIC_KEY(%hd,%s) to " IP_ADDR_S, tmp->len, &tmp->key,
-	   IP_ADDR_V(cl->vpn_ip));
+    syslog(LOG_DEBUG, _("Send PUBLIC_KEY %s to " IP_ADDR_S),
+	   my_public_key_base36, IP_ADDR_V(cl->vpn_ip));
 
-  if((write(cl->meta_socket, tmp, tmp->len+sizeof(*tmp))) < 0)
+  buflen = snprintf(buffer, MAXBUFSIZE, "%d %s\n", PUBLIC_KEY, my_public_key_base36);
+
+  if((write(cl->meta_socket, buffer, buflen)) < 0)
     {
-      syslog(LOG_ERR, "send failed: %s:%d: %m", __FILE__, __LINE__);
+      syslog(LOG_ERR, _("send failed: %s:%d: %m"), __FILE__, __LINE__);
       return -1;
     }
 cp
@@ -271,17 +257,12 @@ cp
 
 int send_calculate(conn_list_t *cl, char *k)
 {
-  calculate_t *tmp;
 cp
-  tmp = xmalloc(strlen(k)+sizeof(*tmp));
-  memset(tmp, 0, sizeof(*tmp));
-  tmp->type = CALCULATE;
-  tmp->len = strlen(k);
-  strcpy(&tmp->key, k);
+  buflen = snprintf(buffer, MAXBUFSIZE, "%d %s\n", CALCULATE, k);
 
-  if((write(cl->meta_socket, tmp, tmp->len+sizeof(*tmp))) < 0)
+  if((write(cl->meta_socket, buffer, buflen)) < 0)
     {
-      syslog(LOG_ERR, "send failed: %s:%d: %m", __FILE__, __LINE__);
+      syslog(LOG_ERR, _("send failed: %s:%d: %m"), __FILE__, __LINE__);
       return -1;
     }
 cp
@@ -290,30 +271,25 @@ cp
 
 int send_key_request(ip_t to)
 {
-  key_req_t *tmp;
   conn_list_t *fw;
 cp
-  tmp = xmalloc(sizeof(*tmp));
-  memset(tmp, 0, sizeof(*tmp));
-  tmp->type = REQ_KEY;
-  tmp->to = to;
-  tmp->from = myself->vpn_ip;
-  tmp->len = 0;
-
   fw = lookup_conn(to);
   if(!fw)
     {
-      syslog(LOG_ERR, "Attempting to send key request to " IP_ADDR_S ", which does not exist?",
+      syslog(LOG_ERR, _("Attempting to send key request to " IP_ADDR_S ", which does not exist?"),
 	     IP_ADDR_V(to));
       return -1;
     }
 
   if(debug_lvl > 2)
-    syslog(LOG_DEBUG, "Sending out request for public key to " IP_ADDR_S,
+    syslog(LOG_DEBUG, _("Sending out request for public key to " IP_ADDR_S),
 	   IP_ADDR_V(fw->nexthop->vpn_ip));
-  if(write(fw->nexthop->meta_socket, tmp, sizeof(*tmp)) < 0)
+
+  buflen = snprintf(buffer, MAXBUFSIZE, "%d %lx %lx\n", REQ_KEY, to, myself->vpn_ip);
+
+  if((write(fw->nexthop->meta_socket, buffer, buflen)) < 0)
     {
-      syslog(LOG_ERR, "send failed: %s:%d: %m", __FILE__, __LINE__);
+      syslog(LOG_ERR, _("send failed: %s:%d: %m"), __FILE__, __LINE__);
       return -1;
     }
   fw->status.waitingforkey = 1;
@@ -323,35 +299,27 @@ cp
 
 int send_key_answer(conn_list_t *cl, ip_t to)
 {
-  key_req_t *tmp;
   conn_list_t *fw;
 cp
-  tmp = xmalloc(sizeof(*tmp)+strlen(my_public_key_base36));
-  memset(tmp, 0, sizeof(*tmp));
-  tmp->type = ANS_KEY;
-  tmp->to = to;
-  tmp->from = myself->vpn_ip;
-  tmp->expiry = my_key_expiry;
-  tmp->len = strlen(my_public_key_base36);
-  strcpy(&(tmp->key), my_public_key_base36);
 
   fw = lookup_conn(to);
   
   if(!fw)
     {
-      syslog(LOG_ERR, "Attempting to send key answer to " IP_ADDR_S ", which does not exist?",
+      syslog(LOG_ERR, _("Attempting to send key answer to " IP_ADDR_S ", which does not exist?"),
 	     IP_ADDR_V(to));
       return -1;
     }
 
-cp
  if(debug_lvl > 2)
-    syslog(LOG_DEBUG, "Sending public key to " IP_ADDR_S,
+    syslog(LOG_DEBUG, _("Sending public key to " IP_ADDR_S),
 	   IP_ADDR_V(fw->nexthop->vpn_ip));
-cp
-  if(write(fw->nexthop->meta_socket, tmp, sizeof(*tmp)+tmp->len) < 0)
+
+  buflen = snprintf(buffer, MAXBUFSIZE, "%d %lx %lx %d %s\n", ANS_KEY, to, myself->vpn_ip, my_key_expiry, my_public_key_base36);
+
+  if((write(fw->nexthop->meta_socket, buffer, buflen)) < 0)
     {
-      syslog(LOG_ERR, "send failed: %s:%d: %m", __FILE__, __LINE__);
+      syslog(LOG_ERR, _("send failed: %s:%d: %m"), __FILE__, __LINE__);
       return -1;
     }
 cp
@@ -369,7 +337,7 @@ int notify_others(conn_list_t *new, conn_list_t *source,
   conn_list_t *p;
 cp
   for(p = conn_list; p != NULL; p = p->next)
-    if(p != new && p != source && p->status.meta && p->protocol_version > PROT_3)
+    if(p != new && p != source && p->status.meta && p->status.active)
       function(p, new);
 cp
   return 0;
@@ -384,7 +352,7 @@ int notify_one(conn_list_t *new)
   conn_list_t *p;
 cp
   for(p = conn_list; p != NULL; p = p->next)
-    if(p != new && p->protocol_version > PROT_3)
+    if(p != new && p->status.active)
       send_add_host(new, p);
 cp
   return 0;
@@ -396,31 +364,25 @@ cp
 
 int basic_info_h(conn_list_t *cl)
 {
-  basic_info_t tmp;
 cp
-  if(read(cl->meta_socket, &((char*)(&tmp))[1], sizeof(tmp)-1) <= 0)
+  if(sscanf(cl->buffer, "%*d %d %lx/%lx:%hx", &cl->protocol_version, &cl->vpn_ip, &cl->vpn_mask, &cl->port) != 4)
     {
-      syslog(LOG_ERR, "%d: Receive failed: %m", __LINE__);
-      return -1;
-    }
-
-  cl->protocol_version = tmp.protocol;
-  cl->port = tmp.portnr;
-  cl->vpn_ip = tmp.vpn_ip;
-  cl->vpn_mask = tmp.vpn_mask;
+       syslog(LOG_ERR, _("got bad BASIC_INFO request: %s"), cl->buffer);
+       return -1;
+    }  
 
-  if(cl->protocol_version < PROT_CURRENT)
+  if(cl->protocol_version != PROT_CURRENT)
     {
-      syslog(LOG_ERR, "Peer uses protocol version %d which is too old.",
+      syslog(LOG_ERR, _("Peer uses incompatible protocol version %d."),
 	     cl->protocol_version);
       return -1;
     }
 
   if(debug_lvl > 2)
-    syslog(LOG_DEBUG, "got BASIC_INFO(%hd," IP_ADDR_S "," IP_ADDR_S ")", cl->port,
+    syslog(LOG_DEBUG, _("got BASIC_INFO(%hd," IP_ADDR_S "," IP_ADDR_S ")"), cl->port,
 	   IP_ADDR_V(cl->vpn_ip), IP_ADDR_V(cl->vpn_mask));
   if(debug_lvl > 1)
-    syslog(LOG_DEBUG, "Peer uses protocol version %d",
+    syslog(LOG_DEBUG, _("Peer uses protocol version %d"),
 	   cl->protocol_version);
 
   if(cl->status.outgoing)
@@ -435,40 +397,24 @@ cp
 	return -1;
       send_passphrase(cl);
     }
-
-  cl->status.active = 0;
 cp
   return 0;
 }
 
 int passphrase_h(conn_list_t *cl)
 {
-  char unused;
-  unsigned short int len;
 cp
-  if(read(cl->meta_socket, &unused, sizeof(unused)) <= 0)
-    {
-      syslog(LOG_ERR, "%d: Receive failed: %m", __LINE__);
-      return -1;
-    }
-
-  if(read(cl->meta_socket, &len, sizeof(len)) <= 0)
-    {
-      syslog(LOG_ERR, "%d: Receive failed: %m", __LINE__);
-      return -1;
-    }
-  
-  cl->pp = xmalloc(len+4);
+  cl->pp = xmalloc(sizeof(*(cl->pp)));
 
-  cl->pp->len = len;
-  if(read(cl->meta_socket, &(cl->pp->phrase), len) <= 0)
+  if(sscanf(cl->buffer, "%*d %as", &(cl->pp->phrase)) != 1)
     {
-      syslog(LOG_ERR, "%d: Receive failed: %m", __LINE__);
+      syslog(LOG_ERR, _("got bad PASSPHRASE request: %s"), cl->buffer);
       return -1;
     }
-  
+  cl->pp->len = strlen(cl->pp->phrase);
+    
   if(debug_lvl > 2)
-    syslog(LOG_DEBUG, "got PASSPHRASE(%hd,...)", len);
+    syslog(LOG_DEBUG, _("got PASSPHRASE"));
 
   if(cl->status.outgoing)
     send_passphrase(cl);
@@ -481,49 +427,45 @@ cp
 int public_key_h(conn_list_t *cl)
 {
   char *g_n;
-  unsigned short int len;
-  char unused;
+  conn_list_t *old;
 cp
-  if(read(cl->meta_socket, &unused, sizeof(unused)) <= 0)
-    {
-      syslog(LOG_ERR, "%d: Receive failed: %m", __LINE__);
-      return -1;
-    }
-  if(read(cl->meta_socket, &len, sizeof(len)) <= 0)
-    {
-      syslog(LOG_ERR, "%d: Receive failed: %m", __LINE__);
-      return -1;
-    }
-
-  g_n = xmalloc(len+2);
-
-  if(read(cl->meta_socket, g_n, len+2) <= 0)
+  if(sscanf(cl->buffer, "%*d %as", &g_n) != 1)
     {
-      syslog(LOG_ERR, "%d: Receive failed: %m", __LINE__);
-      return -1;
-    }
+       syslog(LOG_ERR, _("got bad PUBLIC_KEY request: %s"), cl->buffer);
+       return -1;
+    }  
 
   if(debug_lvl > 2)
-    syslog(LOG_DEBUG, "got PUBLIC_KEY(%hd,%s)", len, g_n);
+    syslog(LOG_DEBUG, _("got PUBLIC_KEY %s"), g_n);
 
   if(verify_passphrase(cl, g_n))
     {
       /* intruder! */
-      syslog(LOG_ERR, "Intruder: passphrase does not match.");
+      syslog(LOG_ERR, _("Intruder: passphrase does not match."));
       return -1;
     }
 
   if(debug_lvl > 2)
-    syslog(LOG_INFO, "Passphrase OK");
+    syslog(LOG_INFO, _("Passphrase OK"));
 
   if(cl->status.outgoing)
     send_public_key(cl);
   else
-    send_ack(cl);
+    {
+      send_ack(cl);
 
-  cl->status.active = 1;
-  notify_others(cl, NULL, send_add_host);
-  notify_one(cl);
+      /* Okay, before we active the connection, we check if there is another entry
+         in the connection list with the same vpn_ip. If so, it presumably is an
+         old connection that has timed out but we don't know it yet. Because our
+         conn_list entry is not active, lookup_conn will skip ourself. */
+
+      while(old=lookup_conn(cl->vpn_ip)) 
+        terminate_connection(old);
+
+      cl->status.active = 1;
+      notify_others(cl, NULL, send_add_host);
+      notify_one(cl);
+    }
 cp
   return 0;
 }
@@ -532,10 +474,10 @@ int ack_h(conn_list_t *cl)
 {
 cp
   if(debug_lvl > 2)
-    syslog(LOG_DEBUG, "got ACK");
+    syslog(LOG_DEBUG, _("got ACK"));
   
   cl->status.active = 1;
-  syslog(LOG_NOTICE, "Connection with %s activated.", cl->hostname);
+  syslog(LOG_NOTICE, _("Connection with %s activated."), cl->hostname);
 cp
   return 0;
 }
@@ -543,7 +485,7 @@ cp
 int termreq_h(conn_list_t *cl)
 {
 cp
-  syslog(LOG_NOTICE, IP_ADDR_S " wants to quit", IP_ADDR_V(cl->vpn_ip));
+  syslog(LOG_NOTICE, _(IP_ADDR_S " wants to quit"), IP_ADDR_V(cl->vpn_ip));
   cl->status.termreq = 1;
   terminate_connection(cl);
 
@@ -555,7 +497,8 @@ cp
 int timeout_h(conn_list_t *cl)
 {
 cp
-  syslog(LOG_NOTICE, IP_ADDR_S " says it's gotten a timeout from us", IP_ADDR_V(cl->vpn_ip));
+  if(!cl->status.active) return -1;
+  syslog(LOG_NOTICE, _(IP_ADDR_S " says it's gotten a timeout from us"), IP_ADDR_V(cl->vpn_ip));
   cl->status.termreq = 1;
   terminate_connection(cl);
 cp
@@ -564,23 +507,25 @@ cp
 
 int del_host_h(conn_list_t *cl)
 {
-  del_host_t tmp;
+  ip_t vpn_ip;
   conn_list_t *fw;
 cp
-  if(read(cl->meta_socket, &((char*)(&tmp))[1], sizeof(tmp)-1) <= 0)
+  if(!cl->status.active) return -1;
+
+  if(sscanf(cl->buffer, "%*d %lx", &vpn_ip) != 1)
     {
-      syslog(LOG_ERR, "%d: Receive failed: %m", __LINE__);
-      return -1;
-    }
+       syslog(LOG_ERR, _("got bad DEL_HOST request: %s"), cl->buffer);
+       return -1;
+    }  
 
   if(debug_lvl > 2)
-    syslog(LOG_DEBUG, "got DEL_HOST for " IP_ADDR_S,
-	   IP_ADDR_V(tmp.vpn_ip));
+    syslog(LOG_DEBUG, _("got DEL_HOST for " IP_ADDR_S),
+	   IP_ADDR_V(vpn_ip));
 
-  if(!(fw = lookup_conn(tmp.vpn_ip)))
+  if(!(fw = lookup_conn(vpn_ip)))
     {
-      syslog(LOG_ERR, "Somebody wanted to delete " IP_ADDR_S " which does not exist?",
-	     IP_ADDR_V(tmp.vpn_ip));
+      syslog(LOG_ERR, _("Somebody wanted to delete " IP_ADDR_S " which does not exist?"),
+	     IP_ADDR_V(vpn_ip));
       return 0;
     }
 
@@ -595,8 +540,9 @@ cp
 int ping_h(conn_list_t *cl)
 {
 cp
+  if(!cl->status.active) return -1;
   if(debug_lvl > 3)
-    syslog(LOG_DEBUG, "responding to ping from " IP_ADDR_S, IP_ADDR_V(cl->vpn_ip));
+    syslog(LOG_DEBUG, _("responding to ping from " IP_ADDR_S), IP_ADDR_V(cl->vpn_ip));
   cl->status.pinged = 0;
   cl->status.got_pong = 1;
 
@@ -608,8 +554,9 @@ cp
 int pong_h(conn_list_t *cl)
 {
 cp
+  if(!cl->status.active) return -1;
   if(debug_lvl > 3)
-    syslog(LOG_DEBUG, "ok, got pong from " IP_ADDR_S, IP_ADDR_V(cl->vpn_ip));
+    syslog(LOG_DEBUG, _("ok, got pong from " IP_ADDR_S), IP_ADDR_V(cl->vpn_ip));
   cl->status.got_pong = 1;
 cp
   return 0;
@@ -617,36 +564,40 @@ cp
 
 int add_host_h(conn_list_t *cl)
 {
-  add_host_t tmp;
+  ip_t real_ip;
+  ip_t vpn_ip;
+  ip_t vpn_mask;
+  unsigned short port;
   conn_list_t *ncn, *fw;
 cp
-  if(read(cl->meta_socket, &((char*)(&tmp))[1], sizeof(tmp)-1) <= 0)
+  if(!cl->status.active) return -1;
+  if(sscanf(cl->buffer, "%*d %lx %lx/%lx:%hx", &real_ip, &vpn_ip, &vpn_mask, &port) != 4)
     {
-      syslog(LOG_ERR, "%d: Receive failed: %m", __LINE__);
-      return -1;
-    }
+       syslog(LOG_ERR, _("got bad ADD_HOST request: %s"), cl->buffer);
+       return -1;
+    }  
 
   if(debug_lvl > 2)
-    syslog(LOG_DEBUG, "Add host request from " IP_ADDR_S, IP_ADDR_V(cl->vpn_ip));
+    syslog(LOG_DEBUG, _("Add host request from " IP_ADDR_S), IP_ADDR_V(cl->vpn_ip));
   if(debug_lvl > 3)
-    syslog(LOG_DEBUG, "got ADD_HOST(" IP_ADDR_S "," IP_ADDR_S ",%hd)",
-	   IP_ADDR_V(tmp.vpn_ip), IP_ADDR_V(tmp.vpn_mask), tmp.portnr);
+    syslog(LOG_DEBUG, _("got ADD_HOST(" IP_ADDR_S "," IP_ADDR_S ",%hd)"),
+	   IP_ADDR_V(vpn_ip), IP_ADDR_V(vpn_mask), port);
 
   /*
     Suggestion of Hans Bayle
   */
-  if((fw = lookup_conn(tmp.vpn_ip)))
+  if((fw = lookup_conn(vpn_ip)))
     {
       notify_others(fw, cl, send_add_host);
       return 0;
     }
 
   ncn = new_conn_list();
-  ncn->real_ip = tmp.real_ip;
-  ncn->vpn_ip = tmp.vpn_ip;
-  ncn->vpn_mask = tmp.vpn_mask;
-  ncn->port = tmp.portnr;
-  ncn->hostname = hostlookup(tmp.real_ip);
+  ncn->real_ip = real_ip;
+  ncn->vpn_ip = vpn_ip;
+  ncn->vpn_mask = vpn_mask;
+  ncn->port = port;
+  ncn->hostname = hostlookup(real_ip);
   ncn->nexthop = cl;
   ncn->next = conn_list;
   conn_list = ncn;
@@ -658,50 +609,52 @@ cp
 
 int req_key_h(conn_list_t *cl)
 {
-  key_req_t tmp;
+  ip_t to;
+  ip_t from;
   conn_list_t *fw;
 cp
-  if(read(cl->meta_socket, &((char*)(&tmp))[1], sizeof(tmp)-1) <= 0)
+  if(!cl->status.active) return -1;
+  if(sscanf(cl->buffer, "%*d %lx %lx", &to, &from) != 2)
     {
-      syslog(LOG_ERR, "%d: Receive failed: %m", __LINE__);
-      return -1;
-    }
+       syslog(LOG_ERR, _("got bad request: %s"), cl->buffer);
+       return -1;
+    }  
 
   if(debug_lvl > 2)
-    syslog(LOG_DEBUG, "got REQ_KEY from " IP_ADDR_S " for " IP_ADDR_S,
-	   IP_ADDR_V(tmp.from), IP_ADDR_V(tmp.to));
+    syslog(LOG_DEBUG, _("got REQ_KEY from " IP_ADDR_S " for " IP_ADDR_S),
+	   IP_ADDR_V(from), IP_ADDR_V(to));
 
-  if((tmp.to & myself->vpn_mask) == (myself->vpn_ip & myself->vpn_mask))
+  if((to & myself->vpn_mask) == (myself->vpn_ip & myself->vpn_mask))
     {  /* hey! they want something from ME! :) */
-      send_key_answer(cl, tmp.from);
+      send_key_answer(cl, from);
       return 0;
     }
 
-  fw = lookup_conn(tmp.to);
+  fw = lookup_conn(to);
   
   if(!fw)
     {
-      syslog(LOG_ERR, "Attempting to forward key request to " IP_ADDR_S ", which does not exist?",
-	     IP_ADDR_V(tmp.to));
+      syslog(LOG_ERR, _("Attempting to forward key request to " IP_ADDR_S ", which does not exist?"),
+	     IP_ADDR_V(to));
       return -1;
     }
 
   if(debug_lvl > 3)
-    syslog(LOG_DEBUG, "Forwarding request for public key to " IP_ADDR_S,
+    syslog(LOG_DEBUG, _("Forwarding request for public key to " IP_ADDR_S),
 	   IP_ADDR_V(fw->nexthop->vpn_ip));
   
-  tmp.type = REQ_KEY;
-  tmp.key = 0;
-  if(write(fw->nexthop->meta_socket, &tmp, sizeof(tmp)) < 0)
+  cl->buffer[cl->reqlen-1] = '\n';
+  
+  if(write(fw->nexthop->meta_socket, cl->buffer, cl->reqlen) < 0)
     {
-      syslog(LOG_ERR, "send failed: %s:%d: %m", __FILE__, __LINE__);
+      syslog(LOG_ERR, _("send failed: %s:%d: %m"), __FILE__, __LINE__);
       return -1;
     }
 cp
   return 0;
 }
 
-void set_keys(conn_list_t *cl, key_req_t *k, char *key)
+void set_keys(conn_list_t *cl, int expiry, char *key)
 {
   char *ek;
 cp
@@ -710,95 +663,89 @@ cp
       cl->public_key = xmalloc(sizeof(*cl->key));
       cl->public_key->key = NULL;
     }
+    
   if(cl->public_key->key)
     free(cl->public_key->key);
-  cl->public_key->length = k->len;
-  cl->public_key->expiry = k->expiry;
-  cl->public_key->key = xmalloc(k->len + 1);
+  cl->public_key->length = strlen(key);
+  cl->public_key->expiry = expiry;
+  cl->public_key->key = xmalloc(cl->public_key->length + 1);
   strcpy(cl->public_key->key, key);
 
   ek = make_shared_key(key);
+  
   if(!cl->key)
     {
       cl->key = xmalloc(sizeof(*cl->key));
       cl->key->key = NULL;
     }
+
   if(cl->key->key)
     free(cl->key->key);
+
   cl->key->length = strlen(ek);
-  cl->key->expiry = k->expiry;
-  cl->key->key = xmalloc(strlen(ek) + 1);
+  cl->key->expiry = expiry;
+  cl->key->key = xmalloc(cl->key->length + 1);
   strcpy(cl->key->key, ek);
 cp
 }
 
 int ans_key_h(conn_list_t *cl)
 {
-  key_req_t tmp;
-  conn_list_t *fw, *gk;
+  ip_t to;
+  ip_t from;
+  int expiry;
   char *key;
+  conn_list_t *fw, *gk;
 cp
-  if(read(cl->meta_socket, &((char*)(&tmp))[1], sizeof(tmp) - 3) <= 0)
+  if(!cl->status.active) return -1;
+  if(sscanf(cl->buffer, "%*d %lx %lx %d %as", &to, &from, &expiry, &key) != 4)
     {
-      syslog(LOG_ERR, "%d: Receive failed: %m", __LINE__);
-      return -1;
-    }
-
-  syslog(LOG_DEBUG, "%08lx %08lx %d %hd", tmp.from, tmp.to, tmp.expiry, tmp.len); 
-  key = xmalloc(tmp.len);
-  
-  if(read(cl->meta_socket, key, tmp.len + 2) <= 0)
-    {
-      syslog(LOG_ERR, "%d: Receive failed: %m", __LINE__);
-      return -1;
-    }
-  syslog(LOG_DEBUG, "%s", key);
+       syslog(LOG_ERR, _("got bad ANS_KEY request: %s"), cl->buffer);
+       return -1;
+    }  
 
   if(debug_lvl > 3)
-    syslog(LOG_DEBUG, "got ANS_KEY from " IP_ADDR_S " for " IP_ADDR_S,
-	   IP_ADDR_V(tmp.from), IP_ADDR_V(tmp.to));
+    syslog(LOG_DEBUG, _("got ANS_KEY from " IP_ADDR_S " for " IP_ADDR_S),
+	   IP_ADDR_V(from), IP_ADDR_V(to));
 
-  if(tmp.to == myself->vpn_ip)
+  if(to == myself->vpn_ip)
     {  /* hey! that key's for ME! :) */
       if(debug_lvl > 2)
-	syslog(LOG_DEBUG, "Yeah! key arrived. Now do something with it.");
-      gk = lookup_conn(tmp.from);
+	syslog(LOG_DEBUG, _("Yeah! key arrived. Now do something with it."));
+      gk = lookup_conn(from);
 
       if(!gk)
         {
-          syslog(LOG_ERR, "Receiving key from " IP_ADDR_S ", which does not exist?",
-	         IP_ADDR_V(tmp.from));
+          syslog(LOG_ERR, _("Receiving key from " IP_ADDR_S ", which does not exist?"),
+	         IP_ADDR_V(from));
           return -1;
         }
 
-      set_keys(gk, &tmp, key);
+      set_keys(gk, expiry, key);
       gk->status.validkey = 1;
       gk->status.waitingforkey = 0;
       flush_queues(gk);
       return 0;
     }
 
-  fw = lookup_conn(tmp.to);
+  fw = lookup_conn(to);
   
   if(!fw)
     {
-      syslog(LOG_ERR, "Attempting to forward key to " IP_ADDR_S ", which does not exist?",
-	     IP_ADDR_V(tmp.to));
+      syslog(LOG_ERR, _("Attempting to forward key to " IP_ADDR_S ", which does not exist?"),
+	     IP_ADDR_V(to));
       return -1;
     }
 
   if(debug_lvl > 2)
-    syslog(LOG_DEBUG, "Forwarding public key to " IP_ADDR_S,
+    syslog(LOG_DEBUG, _("Forwarding public key to " IP_ADDR_S),
 	   IP_ADDR_V(fw->nexthop->vpn_ip));
-  tmp.type = ANS_KEY;
-  if(write(fw->nexthop->meta_socket, &tmp, sizeof(tmp) -2) < 0)
-    {
-      syslog(LOG_ERR, "send failed: %s:%d: %m", __FILE__, __LINE__);
-      return -1;
-    }
-  if(write(fw->nexthop->meta_socket, key, tmp.len + 1) < 0)
+
+  cl->buffer[cl->reqlen-1] = '\n';
+
+  if((write(fw->nexthop->meta_socket, cl->buffer, cl->reqlen)) < 0)
     {
-      syslog(LOG_ERR, "send failed: %s:%d: %m", __FILE__, __LINE__);
+      syslog(LOG_ERR, _("send failed: %s:%d: %m"), __FILE__, __LINE__);
       return -1;
     }
 cp
@@ -807,25 +754,26 @@ cp
 
 int key_changed_h(conn_list_t *cl)
 {
-  key_changed_t tmp;
+  ip_t from;
   conn_list_t *ik;
 cp
-  if(read(cl->meta_socket, &((char*)(&tmp))[1], sizeof(tmp)-1) <= 0)
+  if(!cl->status.active) return -1;
+  if(sscanf(cl->buffer, "%*d %lx", &from) != 1)
     {
-      syslog(LOG_ERR, "%d: Receive failed: %m", __LINE__);
-      return -1;
-    }
+       syslog(LOG_ERR, _("got bad ANS_KEY request: %s"), cl->buffer);
+       return -1;
+    }  
 
   if(debug_lvl > 2)
-    syslog(LOG_DEBUG, "got KEY_CHANGED from " IP_ADDR_S,
-	   IP_ADDR_V(tmp.from));
+    syslog(LOG_DEBUG, _("got KEY_CHANGED from " IP_ADDR_S),
+	   IP_ADDR_V(from));
 
-  ik = lookup_conn(tmp.from);
+  ik = lookup_conn(from);
 
   if(!ik)
     {
-      syslog(LOG_ERR, "Got changed key from " IP_ADDR_S ", which does not exist?",
-	     IP_ADDR_V(tmp.from));
+      syslog(LOG_ERR, _("Got changed key from " IP_ADDR_S ", which does not exist?"),
+	     IP_ADDR_V(from));
       return -1;
     }
 
@@ -833,7 +781,7 @@ cp
   ik->status.waitingforkey = 0;
 
   if(debug_lvl > 3)
-    syslog(LOG_DEBUG, "Forwarding key invalidation request");
+    syslog(LOG_DEBUG, _("Forwarding key invalidation request"));
 
   notify_others(cl, ik, send_key_changed);
 cp