From: thorkill <thkr@hannover.ccc.de>
Date: Thu, 4 May 2017 21:44:56 +0000 (+0200)
Subject: Fix NULL pointer dereference in send_udp_info
X-Git-Tag: release-1.1pre15~16
X-Git-Url: https://tinc-vpn.org/git/browse?p=tinc;a=commitdiff_plain;h=958a751e20270da821fee651ff9ecda8a2afc5d0

Fix NULL pointer dereference in send_udp_info
---

diff --git a/src/protocol_misc.c b/src/protocol_misc.c
index 95bd322e..5bbdc6c7 100644
--- a/src/protocol_misc.c
+++ b/src/protocol_misc.c
@@ -194,6 +194,11 @@ bool send_udp_info(node_t *from, node_t *to) {
 	   farther than the static relay. */
 	to = (to->via == myself) ? to->nexthop : to->via;
 
+	if (to == NULL) {
+		logger(DEBUG_ALWAYS, LOG_ERR, "Something went wrong when selecting relay - possible fake UDP_INFO");
+		return false;
+	}
+
 	/* Skip cases where sending UDP info messages doesn't make sense.
 	   This is done here in order to avoid repeating the same logic in multiple callsites. */