Fix address memory leaks in add_edge_h().
[tinc] / src / protocol_edge.c
1 /*
2     protocol_edge.c -- handle the meta-protocol, edges
3     Copyright (C) 1999-2005 Ivo Timmermans,
4                   2000-2012 Guus Sliepen <guus@tinc-vpn.org>
5                   2009      Michael Tokarev <mjt@corpit.ru>
6
7     This program is free software; you can redistribute it and/or modify
8     it under the terms of the GNU General Public License as published by
9     the Free Software Foundation; either version 2 of the License, or
10     (at your option) any later version.
11
12     This program is distributed in the hope that it will be useful,
13     but WITHOUT ANY WARRANTY; without even the implied warranty of
14     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
15     GNU General Public License for more details.
16
17     You should have received a copy of the GNU General Public License along
18     with this program; if not, write to the Free Software Foundation, Inc.,
19     51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
20 */
21
22 #include "system.h"
23
24 #include "conf.h"
25 #include "connection.h"
26 #include "edge.h"
27 #include "graph.h"
28 #include "logger.h"
29 #include "meta.h"
30 #include "net.h"
31 #include "netutl.h"
32 #include "node.h"
33 #include "protocol.h"
34 #include "utils.h"
35 #include "xalloc.h"
36
37 bool send_add_edge(connection_t *c, const edge_t *e) {
38         bool x;
39         char *address, *port;
40
41         sockaddr2str(&e->address, &address, &port);
42
43         if(e->local_address.sa.sa_family) {
44                 char *local_address, *local_port;
45                 sockaddr2str(&e->local_address, &local_address, &local_port);
46
47                 x = send_request(c, "%d %x %s %s %s %s %x %d %s %s", ADD_EDGE, rand(),
48                                                  e->from->name, e->to->name, address, port,
49                                                  e->options, e->weight, local_address, local_port);
50                 free(local_address);
51                 free(local_port);
52         } else {
53                 x = send_request(c, "%d %x %s %s %s %s %x %d", ADD_EDGE, rand(),
54                                                  e->from->name, e->to->name, address, port,
55                                                  e->options, e->weight);
56         }
57
58         free(address);
59         free(port);
60
61         return x;
62 }
63
64 bool add_edge_h(connection_t *c, const char *request) {
65         edge_t *e;
66         node_t *from, *to;
67         char from_name[MAX_STRING_SIZE];
68         char to_name[MAX_STRING_SIZE];
69         char to_address[MAX_STRING_SIZE];
70         char to_port[MAX_STRING_SIZE];
71         char address_local[MAX_STRING_SIZE];
72         char port_local[MAX_STRING_SIZE];
73         sockaddr_t address, local_address = {{0}};
74         uint32_t options;
75         int weight;
76
77         int parameter_count = sscanf(request, "%*d %*x "MAX_STRING" "MAX_STRING" "MAX_STRING" "MAX_STRING" %x %d "MAX_STRING" "MAX_STRING,
78                                               from_name, to_name, to_address, to_port, &options, &weight, address_local, port_local);
79         if (parameter_count != 6 && parameter_count != 8) {
80                 logger(DEBUG_ALWAYS, LOG_ERR, "Got bad %s from %s (%s)", "ADD_EDGE", c->name,
81                            c->hostname);
82                 return false;
83         }
84
85         /* Check if names are valid */
86
87         if(!check_id(from_name) || !check_id(to_name)) {
88                 logger(DEBUG_ALWAYS, LOG_ERR, "Got bad %s from %s (%s): %s", "ADD_EDGE", c->name,
89                            c->hostname, "invalid name");
90                 return false;
91         }
92
93         if(seen_request(request))
94                 return true;
95
96         /* Lookup nodes */
97
98         from = lookup_node(from_name);
99         to = lookup_node(to_name);
100
101         if(tunnelserver &&
102            from != myself && from != c->node &&
103            to != myself && to != c->node) {
104                 /* ignore indirect edge registrations for tunnelserver */
105                 logger(DEBUG_PROTOCOL, LOG_WARNING,
106                    "Ignoring indirect %s from %s (%s)",
107                    "ADD_EDGE", c->name, c->hostname);
108                 return true;
109         }
110
111         if(!from) {
112                 from = new_node();
113                 from->name = xstrdup(from_name);
114                 node_add(from);
115         }
116
117         if(!to) {
118                 to = new_node();
119                 to->name = xstrdup(to_name);
120                 node_add(to);
121         }
122
123
124         /* Convert addresses */
125
126         address = str2sockaddr(to_address, to_port);
127         if(parameter_count >= 8)
128                 local_address = str2sockaddr(address_local, port_local);
129
130         /* Check if edge already exists */
131
132         e = lookup_edge(from, to);
133
134         if(e) {
135                 bool new_address = sockaddrcmp(&e->address, &address);
136                 // local_address.sa.sa_family will be 0 if we got it from older tinc versions
137                 // local_address.sa.sa_family will be 255 (AF_UNKNOWN) if we got it from newer versions
138                 // but for edge which does not have local_address
139                 bool new_local_address = local_address.sa.sa_family && local_address.sa.sa_family != AF_UNKNOWN &&
140                         sockaddrcmp(&e->local_address, &local_address);
141
142                 if(e->weight == weight && e->options == options && !new_address && !new_local_address) {
143                         sockaddrfree(&address);
144                         sockaddrfree(&local_address);
145                         return true;
146                 }
147
148                 if(from == myself) {
149                         logger(DEBUG_PROTOCOL, LOG_WARNING, "Got %s from %s (%s) for ourself which does not match existing entry",
150                                            "ADD_EDGE", c->name, c->hostname);
151                         send_add_edge(c, e);
152                         sockaddrfree(&address);
153                         sockaddrfree(&local_address);
154                         return true;
155                 }
156
157                 logger(DEBUG_PROTOCOL, LOG_WARNING, "Got %s from %s (%s) which does not match existing entry",
158                                    "ADD_EDGE", c->name, c->hostname);
159
160                 e->options = options;
161
162                 if(new_address) {
163                         sockaddrfree(&e->address);
164                         e->address = address;
165                 } else {
166                         sockaddrfree(&address);
167                 }
168
169                 if(new_local_address) {
170                         sockaddrfree(&e->local_address);
171                         e->local_address = local_address;
172                 } else {
173                         sockaddrfree(&local_address);
174                 }
175
176                 if(e->weight != weight) {
177                         splay_node_t *node = splay_unlink(edge_weight_tree, e);
178                         e->weight = weight;
179                         splay_insert_node(edge_weight_tree, node);
180                 }
181         } else if(from == myself) {
182                 logger(DEBUG_PROTOCOL, LOG_WARNING, "Got %s from %s (%s) for ourself which does not exist",
183                                    "ADD_EDGE", c->name, c->hostname);
184                 contradicting_add_edge++;
185                 e = new_edge();
186                 e->from = from;
187                 e->to = to;
188                 send_del_edge(c, e);
189                 free_edge(e);
190                 sockaddrfree(&address);
191                 sockaddrfree(&local_address);
192                 return true;
193         } else {
194                 e = new_edge();
195                 e->from = from;
196                 e->to = to;
197                 e->address = address;
198                 e->local_address = local_address;
199                 e->options = options;
200                 e->weight = weight;
201                 edge_add(e);
202         }
203
204         /* Tell the rest about the new edge */
205
206         if(!tunnelserver)
207                 forward_request(c, request);
208
209         /* Run MST before or after we tell the rest? */
210
211         graph();
212
213         return true;
214 }
215
216 bool send_del_edge(connection_t *c, const edge_t *e) {
217         return send_request(c, "%d %x %s %s", DEL_EDGE, rand(),
218                                                 e->from->name, e->to->name);
219 }
220
221 bool del_edge_h(connection_t *c, const char *request) {
222         edge_t *e;
223         char from_name[MAX_STRING_SIZE];
224         char to_name[MAX_STRING_SIZE];
225         node_t *from, *to;
226
227         if(sscanf(request, "%*d %*x "MAX_STRING" "MAX_STRING, from_name, to_name) != 2) {
228                 logger(DEBUG_ALWAYS, LOG_ERR, "Got bad %s from %s (%s)", "DEL_EDGE", c->name,
229                            c->hostname);
230                 return false;
231         }
232
233         /* Check if names are valid */
234
235         if(!check_id(from_name) || !check_id(to_name)) {
236                 logger(DEBUG_ALWAYS, LOG_ERR, "Got bad %s from %s (%s): %s", "DEL_EDGE", c->name,
237                            c->hostname, "invalid name");
238                 return false;
239         }
240
241         if(seen_request(request))
242                 return true;
243
244         /* Lookup nodes */
245
246         from = lookup_node(from_name);
247         to = lookup_node(to_name);
248
249         if(tunnelserver &&
250            from != myself && from != c->node &&
251            to != myself && to != c->node) {
252                 /* ignore indirect edge registrations for tunnelserver */
253                 logger(DEBUG_PROTOCOL, LOG_WARNING,
254                    "Ignoring indirect %s from %s (%s)",
255                    "DEL_EDGE", c->name, c->hostname);
256                 return true;
257         }
258
259         if(!from) {
260                 logger(DEBUG_PROTOCOL, LOG_ERR, "Got %s from %s (%s) which does not appear in the edge tree",
261                                    "DEL_EDGE", c->name, c->hostname);
262                 return true;
263         }
264
265         if(!to) {
266                 logger(DEBUG_PROTOCOL, LOG_ERR, "Got %s from %s (%s) which does not appear in the edge tree",
267                                    "DEL_EDGE", c->name, c->hostname);
268                 return true;
269         }
270
271         /* Check if edge exists */
272
273         e = lookup_edge(from, to);
274
275         if(!e) {
276                 logger(DEBUG_PROTOCOL, LOG_WARNING, "Got %s from %s (%s) which does not appear in the edge tree",
277                                    "DEL_EDGE", c->name, c->hostname);
278                 return true;
279         }
280
281         if(e->from == myself) {
282                 logger(DEBUG_PROTOCOL, LOG_WARNING, "Got %s from %s (%s) for ourself",
283                                    "DEL_EDGE", c->name, c->hostname);
284                 contradicting_del_edge++;
285                 send_add_edge(c, e);    /* Send back a correction */
286                 return true;
287         }
288
289         /* Tell the rest about the deleted edge */
290
291         if(!tunnelserver)
292                 forward_request(c, request);
293
294         /* Delete the edge */
295
296         edge_del(e);
297
298         /* Run MST before or after we tell the rest? */
299
300         graph();
301
302         /* If the node is not reachable anymore but we remember it had an edge to us, clean it up */
303
304         if(!to->status.reachable) {
305                 e = lookup_edge(to, myself);
306                 if(e) {
307                         if(!tunnelserver)
308                                 send_del_edge(everyone, e);
309                         edge_del(e);
310                 }
311         }
312
313         return true;
314 }