Fix UBSAN warnings about conversions and overflows.
authorKirill Isakov <is-kir@ya.ru>
Sun, 15 Aug 2021 17:25:04 +0000 (23:25 +0600)
committerGuus Sliepen <guus@tinc-vpn.org>
Sun, 15 Aug 2021 18:14:05 +0000 (20:14 +0200)
src/route.c
src/subnet.c

index 26a8aab..69d0ba7 100644 (file)
@@ -485,7 +485,7 @@ static void clamp_mss(const node_t *source, const node_t *via, vpn_packet_t *pac
                csum += csum >> 16;
                csum ^= 0xffff;
                DATA(packet)[start + 16] = csum >> 8;
-               DATA(packet)[start + 17] = csum;
+               DATA(packet)[start + 17] = csum & 0xff;
                break;
        }
 }
index 602177f..17dd39e 100644 (file)
@@ -83,7 +83,7 @@ static uint32_t hash_function_ipv6_t(const ipv6_t *p) {
        uint32_t hash = hash_seed;
 
        for(int i = 0; i < 4; i++) {
-               hash += fullwidth[i];
+               hash = wrapping_add32(hash, fullwidth[i]);
                hash = wrapping_mul32(hash, 0x9e370001U);
        }
 
@@ -95,7 +95,7 @@ static uint32_t hash_function_mac_t(const mac_t *p) {
        uint32_t hash = hash_seed;
 
        for(int i = 0; i < 3; i++) {
-               hash += halfwidth[i];
+               hash = wrapping_add32(hash, halfwidth[i]);
                hash = wrapping_mul32(hash, 0x9e370001U);
        }